-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(install): Add unpacker for 'wix', 'nsis' and 'inno' installer #3502
base: develop
Are you sure you want to change the base?
Conversation
Fixed. |
Inno type is done. |
How about something like |
Could you support Here is a use case. servo.json
|
This will lead to too complicated manifest for these |
There is disadvantage from url: url
hash: hash
innosetup: true
architecture:
64bit:
installer:
script: do something
32bit:
installer:
script: do something With these changes there is not possible to do this: url: url
hash: hash
installer:
type: inno
architecture:
64bit:
installer:
script: do something
32bit:
installer:
script: do something You need to duplicate these lines to both architectures url: url
hash: hash
installer:
type: inno
architecture:
64bit:
installer:
type: inno
script: do something
32bit:
installer:
type: inno
script: do something |
The first Or why not use PS. For most inno-setup archive, new added |
ScoopInstaller/Main#512 doesn't work with this. Only the first url will be extracted. Any workarounds? For example,
? |
ScoopInstaller/Extras@7b34c19 is the reason why i would rather have separate Also installer property is not reflecting it's real usage. Since |
Since they are 'installer's, I put the params in In the I got an idea that we may patch |
Since this PR is a mixture of fixing, refactoring and new features, I'll try to separate the functionality of each line of code and keep this as a pure feature adding one. |
installer.type
(nsis|wix|inno
)nsis
:Expand-Installer
accepts$Architecture
(64bit|32bit
) and unpack Electron's NSIS installer ($PLUGINSDIR/app-32|64.7z
)wix
:Expand-WixInstaller
useExpand-DarkArchive
first and thenExpand-MsiArchive
all msi underAttachedContainer
except those excluded byinstaller.exclude
inno
: Moveinnosetup
here for consistency, i.e.innosetup:true
=installer.type:inno
(autoupdate will removeinnosetup:true
and addinstaller.type:inno
automatically),installer.include
are MUST HAVE components whileinstaller.exclude
are MUST HAVE NOT components{tmp}
and those excluded byinstaller.exclude
, seefreedownloadmanager
example ({code_CefInstallDir}
is auto extracted)installer:inno
as shortcut ofinstaller.type:inno
(thank @linsui)python
andmro
Main#121, multi: Use installer.type for nsis and inno type apps Extras#2264Closes #3700
Some Examples:
`python` manifest
`mro` manifest
`simplenote` manifest
`gimp` manifest
`scilab` manifest
`freedownloadmanager` manifest