opt(decompress): Add [Array] and pipeline support to Expand-XXX's params
#3534
Conversation
|
@niheaven Could you also look into this? {
"version": "5.4.6.0",
"url": "http://www.vieas.com/software/dl/Vieas5460_32.zip#/cosi",
"pre_install": "\"$dir\\$fname\" | Expand-7zipArchive; 'WRONG'",
"post_install": "\"$dir\\$fname\" | Expand-7zipArchive -DestinationPath $dir; 'OK'"
}When using pipeline, default DestinationPath is not resolved as
|
|
OK.Nevermind. This come from PowerShell precedence of execution. Parameters are validated and binded before pipeline input processing.
This could be solved with removing default from |
|
@Ash258 I've found it and fixed in this PR, it should be okay when this is merged. 😄 |
| It "accept array path param" -Skip:$isUnix { | ||
| $to = test_extract "Expand-InnoArchive" @($test) | ||
| $to | Should -Exist | ||
| "$to\empty" | Should -Exist |
There was a problem hiding this comment.
Incosistency. You are using Join-Path in #L74
| Expand-7zipArchive $Path $DestinationPath -Removal | ||
| return | ||
| process { | ||
| if (!$DestinationPath) { |
There was a problem hiding this comment.
Why is this in process block?
| # Remove original archive file | ||
| Remove-Item $currentPath -Force | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| function Expand-ZipArchive { |
| @@ -39,12 +39,13 @@ function Expand-7zipArchive { | |||
| [CmdletBinding()] | |||
| param ( | |||
| [Parameter(Mandatory = $true, Position = 0, ValueFromPipeline = $true)] | |||
There was a problem hiding this comment.
Why this is not ValueFromPipelineByPropertyName?
You just limit me with usage of custom object.
| switch ($Overwrite) { | ||
| "All" { $ArgList += "-aoa" } | ||
| "Skip" { $ArgList += "-aos" } | ||
| "Rename" { $ArgList += "-aou" } | ||
| } |
| } | ||
| $currentDestinationPath = $currentDestinationPath.TrimEnd("\") | ||
| if ($currentExtractDir) { | ||
| $OriDestinationPath = $currentDestinationPath |
There was a problem hiding this comment.
local variable
| $OriDestinationPath = $currentDestinationPath | |
| $oriDestinationPath = $currentDestinationPath |
| "^[^{].*" { $ArgList += "-c{app}\$currentExtractDir" } | ||
| "^{.*" { $ArgList += "-c$currentExtractDir" } | ||
| Default { $ArgList += "-c{app}" } | ||
| } |
There was a problem hiding this comment.
- single quotes
- default is lowercased when switch is lowercased
| $currentExtractDir = $null | ||
| } | ||
| if ($currentExtractDir) { | ||
| $OriDestinationPath = $currentDestinationPath |
| # try to fall back to 7zip if path is too long | ||
| if (Test-HelperInstalled -Helper 7zip) { | ||
| Expand-7zipArchive $currentPath $currentDestinationPath -Removal | ||
| return |
There was a problem hiding this comment.
Why would you break whole foreach?
Now
Expand-xxxfunctions accept [Array] params (Path,DestinationPath,ExtractDir), and work for pipeline params (aa, bb, cc | Expand-xxxor@(aa, bb, cc) | Expand-xxx.No more
ForEach-Object { Expand-xxx $_ }.Useful for install script in manifests.