Feature: Option to force lessmsi

[se35710]

Some manifest require the usage of lessmsi to extract MSI-files, for example libreoffice-fresh in Extras and ojdkbuild-full in Java.

If everyone agrees, I'll add an extra boolean property lessmsi, with a default of false if not defined.

[rashil2000]

Doesn't scoop automatically install lessmsi when it needs it, for example when installing python?

[se35710]

Not that I am aware of, unless I am missing something. The logic in decompress.ps1 check only for MSIEXTRACT_USE_LESSMSI, and if its not enabled or false, msiexec.exe is run.

Scoop/lib/decompress.ps1

Lines 199 to 205 in 59088a9

	if ((get_config MSIEXTRACT_USE_LESSMSI)) {
	$MsiPath = Get-HelperPath -Helper Lessmsi
	$ArgList = @('x', "`"$Path`"", "`"$DestinationPath\\`"")
	} else {
	$MsiPath = 'msiexec.exe'
	$ArgList = @('/a', "`"$Path`"", '/qn', "TARGETDIR=`"$DestinationPath\\SourceDir`"")
	}

Of the Python manifests, only the python27.json and -beta manifests uses MSI, and if MSIEXTRACT_USE_LESSMSI is not configured, the normal msiexec.exe is run instead. Python 2.7 does under normal circumstances install with msiexec.exe.

Trying to work around the problem with pre_install will fail, since it is run after extraction. Adding notes to the manifest to help the user understand why the installation failed will not work, as it is only shown after a successful installation.

[rashil2000]

Just did a fresh install of python, and MSIEXTRACT_USE_LESSMSI is unset - it seems to install lessmsi automatically:

[se35710]

Looking again at the Python 3 manifests, I see that we use Expand-MsiArchive (for reference, see line 57 in python.json).

When that is the case, the dependency of lessmsi is pulled in:

Scoop/lib/depends.ps1

Lines 64 to 66 in 37a8869

	if($script -like '*Expand-MsiArchive *' -or $script -like '*extract_msi *') {
	$deps += 'lessmsi'
	}

However, lessmsi is never executed, unless MSIEXTRACT_USE_LESSMSI is set to True (see comment above).

Maybe this feature could be added to #3502? Maybe we could revive the old deprecated installer.type:msi, or installer.type:lessmsi.

[HUMORCE]

lessmsi should be set as default msi extractor.

[se35710]

Not sure about that; msiexec is available by default, so it's only in a few manifests where msiexec do not work we need lessmsi.

[JTBrinkmann]

Same issue with azure-cli (related issue).

As it isn't entirely clear, I assume that @se35710 suggests a new option in the app manifests to force lessmsi.

possible alternatives:

• if msi extraction with msiexec fails, scoop retries with lessmsi automatically
• if msi extraction with msiexec fails, scoop prompts the user to retry with lessmsi

[rashil2000]

Same issue with azure-cli (related issue).

As it isn't entirely clear, I assume that @se35710 suggests a new option in the app manifests to force lessmsi.

Seems like a doable idea. The manifest can contain another field called lessmsi, similar to innounp, which will use LessMSI instead of MSIExec.

Would you like to work on it?