-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gimp: Update to version 2.10.28 #7028
Conversation
add autoupdate section
@RCJacH @sdellenb @2ion @stmax82 could you look into this? https://github.com/pratikpc/scoop-extras/blob/pratikpc-gimp-update/bucket/gimp.json I made a few updates with an updated hash, autoupdate and checkver It's updating on my end. If this is correct, we could update your commit with this and merge |
checked with checkver.ps1 add separation of major, minor, and patch version numbers add another URL with hashes
For autoupdate: Why not #3814 (comment); How to: ScoopInstaller/Scoop#3518 |
@pratikpc Looks good so far (Windows 10, 64bit): λ scoop install https://raw.githubusercontent.com/pratikpc/scoop-extras/pratikpc-gimp-update/bucket/gimp.json
Installing 'gimp' (2.10.28) [64bit]
Loading gimp-2.10.28-setup.exe from cache
Checking hash of gimp-2.10.28-setup.exe ... ok.
Extracting gimp-2.10.28-setup.exe ... done.
Running installer script...
Linking ~\scoop\apps\gimp\current => ~\scoop\apps\gimp\2.10.28
Creating shim for 'gimp-console-2.10'.
Creating shim for 'gimp-console'.
Creating shim for 'gimp'.
Creating shim for 'gimptool-2.0'.
Creating shim for 'gimptool'.
Creating shortcut for GIMP (gimp-2.10.exe)
Persisting etc\gimp
Persisting share\gimp
'gimp' (2.10.28) was installed successfully! |
remove architecture blocks (since both 32bit and 64bit uses the same file) simplify checkver and autoupdate block to use $majorVersion and $minorVersion variables
I made another commit to remove architecture blocks and simplified version variables in checkver and autoupdate. I then noticed that the other part of the manifest was heavily based on Gimp version 2.0, specifically 2.10, as many exe names were hardcoded with 2.10 version numbers. Is it possible and recommended to use variable version numbers in "bin" and "shortcuts" blocks? Or is it something to be updated manually after a major/minor version bump? The "script" section of "installer" is outside of my ability to understand and edit :( |
fix autoupdate.url for cases with build number
add autoupdate section