Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gimp: Update to version 2.10.28 #7028

Merged
merged 5 commits into from
Nov 4, 2021
Merged

gimp: Update to version 2.10.28 #7028

merged 5 commits into from
Nov 4, 2021

Conversation

RCJacH
Copy link
Contributor

@RCJacH RCJacH commented Oct 15, 2021

add autoupdate section

add autoupdate section
bucket/gimp.json Outdated Show resolved Hide resolved
bucket/gimp.json Outdated Show resolved Hide resolved
@pratikpc
Copy link
Contributor

@RCJacH @sdellenb @2ion @stmax82 could you look into this?

https://github.com/pratikpc/scoop-extras/blob/pratikpc-gimp-update/bucket/gimp.json

I made a few updates with an updated hash, autoupdate and checkver

It's updating on my end.

If this is correct, we could update your commit with this and merge

checked with checkver.ps1
add separation of major, minor, and patch version numbers
add another URL with hashes
@niheaven
Copy link
Member

niheaven commented Nov 1, 2021

For autoupdate: Why not #3814 (comment); How to: ScoopInstaller/Scoop#3518
For installer: ScoopInstaller/Scoop#3502

@sdellenb
Copy link
Contributor

sdellenb commented Nov 2, 2021

@pratikpc Looks good so far (Windows 10, 64bit):

λ scoop install https://raw.githubusercontent.com/pratikpc/scoop-extras/pratikpc-gimp-update/bucket/gimp.json
Installing 'gimp' (2.10.28) [64bit]
Loading gimp-2.10.28-setup.exe from cache
Checking hash of gimp-2.10.28-setup.exe ... ok.
Extracting gimp-2.10.28-setup.exe ... done.
Running installer script...
Linking ~\scoop\apps\gimp\current => ~\scoop\apps\gimp\2.10.28
Creating shim for 'gimp-console-2.10'.
Creating shim for 'gimp-console'.
Creating shim for 'gimp'.
Creating shim for 'gimptool-2.0'.
Creating shim for 'gimptool'.
Creating shortcut for GIMP (gimp-2.10.exe)
Persisting etc\gimp
Persisting share\gimp
'gimp' (2.10.28) was installed successfully!

remove architecture blocks (since both 32bit and 64bit uses the same file)
simplify checkver and autoupdate block to use $majorVersion and $minorVersion variables
@RCJacH
Copy link
Contributor Author

RCJacH commented Nov 3, 2021

I made another commit to remove architecture blocks and simplified version variables in checkver and autoupdate.

I then noticed that the other part of the manifest was heavily based on Gimp version 2.0, specifically 2.10, as many exe names were hardcoded with 2.10 version numbers.

Is it possible and recommended to use variable version numbers in "bin" and "shortcuts" blocks? Or is it something to be updated manually after a major/minor version bump?

The "script" section of "installer" is outside of my ability to understand and edit :(

bucket/gimp.json Outdated Show resolved Hide resolved
@pratikpc pratikpc requested a review from issaclin32 November 4, 2021 12:10
@pratikpc
Copy link
Contributor

pratikpc commented Nov 4, 2021

Both checkver and autoupdate are correct and work

If there are issues in the GIMP script can some @ScoopInstaller/maintainers also help @RCJacH help out?

I am facing the same issue @RCJacH IS

@issaclin32 issaclin32 merged commit 1686842 into ScoopInstaller:master Nov 4, 2021
@RCJacH RCJacH deleted the patch-1 branch January 11, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants