-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for console applications only #2921
Wait for console applications only #2921
Conversation
Neat! 😮😍 |
I guess we should not merge it. I've just understood that some people open programs from Win+R. In this case they would have flickering black window of shim if they run GUI application. I guess we should rewrite this to PowerShell, and run while shimming, setting a flag in |
Finally, I decided not to skip waiting in GUI mode because some programs may rely on exit time. For example |
This issue should be fixed in #3998, which was merged into master. To use, type:
or
Eventually, one of those shims (probably kiennq) will be made the default. If this issue is still a problem after trying both solutions above, please reopen this issue. Thanks! |
This comment was marked as resolved.
This comment was marked as resolved.
@excitoon My apologies for closing this. I erroneously thought this issue was fixed by the new shims. Thank you for pointing out that I was mistaken, and for developing this solution. |
I resolved the conflicts, but more work needs to be done before this can be merged, so I am going to convert to a draft. |
@rasa what shall I do now? I actually switched back to Linux since these times :) |
@excitoon Since it was my screw up, I will take on this PR, and move it forward, if that's OK with you. Thanks again for your help. |
@rasa okay, no problem, I'm actually not good in PowerShell, anyway |
@rasa I just thought we can add a shim for running some applications (16-bit MZ) in DosBox. That is the thing Chocolatey definitely miss. |
Hi @rasa . Is there any news? I noticed modern shims can't be killed with Ctrl+C, this is quite inconvenient if you run desktop apps from console. |
Merged in #5559 |
Follow up for #1606 .
Possibly as an example and possibly as a real solution. This code should be pretty fast because at the moment of execution application is already read and mapped into virtual memory.
But we might want it to be run at install time and pass wait flag as an argument, I don't know.