Add alt-shim support (fixes #3634) #3998
Conversation
|
Testing instructions are here. |
|
Can those that have tested this PR, please report your success/failure here. I tested both alternate shims and both worked fine. |
|
I tested them too and it is definitely an improvement. I did not encounter any issues, and the console flickering when launching a GUI from Win+R is gone. Keyboard interrupts also work correctly. |
|
If there are no objections, I will merge this into develop |
|
@rasa I suggest releasing previous commits in develop branch into the master branch before merging this (https://github.com/lukesampson/scoop/compare/develop). |
|
A little late to the party, but I've been using this for a little over a week with no issues. Keyboard interrupts work as expected everywhere, which was my biggest problem. |
lib/core.ps1
Outdated
| switch ($shim_version) { | ||
| '71' { $shim_path = "$(versiondir 'scoop' 'current')\supporting\shims\71\shim.exe" } | ||
| 'kiennq' { $shim_path = "$(versiondir 'scoop' 'current')\supporting\shims\kiennq\shim.exe" } | ||
| 'default' { true } |
There was a problem hiding this comment.
shouldn't this $true instead?
Or nothing should be put here.
| 'default' { true } | |
| 'default' {} |
|
Do you have instructions on how to enable this on my local scoop installation? |
|
The issue with ctrl + c killing PowerShell Core instances is very frustrating in my day to day use. Is there any kind of timeline on when this will be merged and available? |
|
This is mandatory to merge to continue recommend scoop to people, what are the problems that stop it from being added to master ? Branch/Repo shenanigans are not interesting to me. |
|
OK, based on the feedback above, I'd will do the following after freshening this PR with the fix above, kiennq's latest release (2.2.1), and a little more testing:
I feel confident this will not introduce any issues, but if it does, we can always roll back, if needed. |
|
@rasa when will this make it to master? |
|
OK, let's do it now. We can always roll back if there are issues. |
|
OK, develop has been merged into master. I also tagged the release at 2020-11-26. |
Tested and working locally with both 71 and kiennq shims. See #3634 for details.
Hopefully:
Fixes #3294: Killing the shim process does not kill the child process,
Fixes #2921: Wait for console applications only,
Fixes #2339: python in cmd Ctrl+C problem,
Fixes #2006: Windows cmd gvim.exe shim waits for subprocess,
Fixes #1896: Handle Control-C in shim wrapper,
Fixes #1606: Support shims to both console and GUI apps,
Fixes ScoopInstaller/Extras#2801 : Putty shims open a blank window,