[Bugfix] Handle all-caps address QR data; refactor/cleanup; more tests #667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdlcdl
reviewed
Jan 21, 2025
src/seedsigner/models/decode_qr.py
Outdated
| # Native Segwit (single sig or multisig), mainnet | ||
| self.address_type = (SettingsConstants.TAPROOT, SettingsConstants.MAINNET) | ||
| elif addr_prefix == "bc1p": | ||
| # Native Segwit (single sig or multisig), mainnet |
There was a problem hiding this comment.
This and following 2 "elif" comments could be Taproot instead of Native Segwit
There was a problem hiding this comment.
Removed those code comments entirely as they don't add any clarifying information.
|
As of a90e7a6, ACK tested fairly thoroughly with all supported address types.
|
5 tasks
|
ACK and tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #665
This pull request is categorized as a:
Checklist
pytestand made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: