[New Feature] Enable basic p2tr address verification #669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Address verification flow (scan an address as a QR, select seed, brute force addr generation to find a match) had left taproot support disabled. That must have been early into our initial taproot support. But there's no reason to leave it disabled now.
"abandon" * 11 seed:
![](https://private-user-images.githubusercontent.com/934746/405268629-9888b9f6-8455-49b4-8b09-ad29938f2cc0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NjgyMTQsIm5iZiI6MTczOTY2NzkxNCwicGF0aCI6Ii85MzQ3NDYvNDA1MjY4NjI5LTk4ODhiOWY2LTg0NTUtNDliNC04YjA5LWFkMjk5MzhmMmNjMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwMTA1MTRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lY2NhM2I5MzExMDhiNzA4MzllOGM5NWQyZDYzNmM3YjVmYjVhNTllODFkMmNhYzNhNzAwN2QwZWM3NTllMTkxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Zc_oJtJnfqhXv6zOIc8TojysR0HJJ_PIHdVJa8MgEPs)
Test p2tr address QR (change addr @ index 48):
![](https://private-user-images.githubusercontent.com/934746/405268636-255330af-ea99-45ce-8ac5-144b65cde507.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NjgyMTQsIm5iZiI6MTczOTY2NzkxNCwicGF0aCI6Ii85MzQ3NDYvNDA1MjY4NjM2LTI1NTMzMGFmLWVhOTktNDVjZS04YWM1LTE0NGI2NWNkZTUwNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwMTA1MTRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mZWM2YTY5MTE4YzFjMWE2NjlkNzIxNGY0NDI4ODM2MWMxYWIxMjQ0NTk3MTA5M2ExMmUxYjQ2MzI4NzljM2MxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.VQwp6zSluLGHUXOy9BZrtxjl00VIByzHp_6NLHqzoYE)
Verification result:
![](https://private-user-images.githubusercontent.com/934746/405268638-52302f56-0444-4f19-928d-1514156388a7.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NjgyMTQsIm5iZiI6MTczOTY2NzkxNCwicGF0aCI6Ii85MzQ3NDYvNDA1MjY4NjM4LTUyMzAyZjU2LTA0NDQtNGYxOS05MjhkLTE1MTQxNTYzODhhNy5qcGc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE2JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNlQwMTA1MTRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mMzMyMjgxZTUwOTc2OWE3NTBjNWE3ODQ3Yjg0OTY2YTZhOWVkMzM2NTAwYWNjMzc1NGNlNzM1ODNhMDlmMzY5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.TGSVluCh2gXBz3DBC3PjY8HWGXo7I9XDMP0K5Oygj6s)
This pull request is categorized as a:
Checklist
pytest
and made sure all unit tests pass before sumbitting the PRIf you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os: