Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Enable basic p2tr address verification #669

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

kdmukai
Copy link
Contributor

@kdmukai kdmukai commented Jan 21, 2025

Description

Address verification flow (scan an address as a QR, select seed, brute force addr generation to find a match) had left taproot support disabled. That must have been early into our initial taproot support. But there's no reason to leave it disabled now.


"abandon" * 11 seed:

Test p2tr address QR (change addr @ index 48):

Verification result:


This pull request is categorized as a:

  • New feature

Checklist

  • I’ve run pytest and made sure all unit tests pass before sumbitting the PR

If you modified or added functionality/workflow, did you add new unit tests?

  • Yes

I have tested this PR on the following platforms/os:

@jdlcdl
Copy link

jdlcdl commented Jan 21, 2025

I tested a variation of this pr as of b541112... I merged pr #667 on top without any conflicts.

ACK tested as above,

This handles taproot verification... even for BlueWallet capitalization (for when they support taproot), and this didn't break other fixes that were solved in pr 667.

@newtonick
Copy link
Collaborator

ACK, tested and reviewed.

@newtonick newtonick merged commit 1e9caa5 into SeedSigner:dev Jan 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Merged Not Yet Released
Development

Successfully merging this pull request may close these issues.

3 participants