fix: Add Pydantic v1 shim #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was auto-corrected previously, as seen in the log statements.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #882 +/- ##
==========================================
- Coverage 81.98% 81.96% -0.03%
==========================================
Files 159 161 +2
Lines 10375 10383 +8
==========================================
+ Hits 8506 8510 +4
- Misses 1869 1873 +4
|
This allows other dependencies to be upgraded, whilst Alibi Detect itself is migrated.
mauicv
approved these changes
Mar 5, 2024
alibi_detect/utils/pydantic_v1/fields/tests/test_import_pydantic_v1_fields.py
Show resolved
Hide resolved
sakoush
reviewed
Apr 23, 2024
jesse-c
added a commit
that referenced
this pull request
Apr 23, 2024
This is a follow-up to where the Pydantic v1 shim was added [1]. It's inspired by Ray's approach [2]. This locks the version in the CI and I think that's okay since we don't need to keep on updating them, as they're intended as smoke tests. [1] #882 (comment) [2] ray-project/ray#40451
jesse-c
added a commit
that referenced
this pull request
Apr 24, 2024
This is a follow-up to where the Pydantic v1 shim was added [1]. It's inspired by Ray's approach [2]. This locks the version in the CI and I think that's okay since we don't need to keep on updating them, as they're intended as smoke tests. [1] #882 (comment) [2] ray-project/ray#40451
jesse-c
added a commit
that referenced
this pull request
Apr 24, 2024
* test: Add Pydantic version to matrix variable This is a follow-up to where the Pydantic v1 shim was added [1]. It's inspired by Ray's approach [2]. This locks the version in the CI and I think that's okay since we don't need to keep on updating them, as they're intended as smoke tests. [1] #882 (comment) [2] ray-project/ray#40451 * build: Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows other dependencies to be upgraded, whilst Alibi Detect itself is migrated.
I've made some small QoL improvements around the DevEx.