test: Add Pydantic version to matrix variable #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesse-c
force-pushed
the
add-test-for-pydantic-v1-v2-explicitly
branch
2 times, most recently
from
f7db250 to
55d7fd4
Compare
mauicv
approved these changes
Apr 23, 2024
jesse-c
force-pushed
the
add-test-for-pydantic-v1-v2-explicitly
branch
from
430a3aa to
eb84cf2
Compare
|
There are docs and static checks fails, which are unrelated to the changes here [1]. [1] https://github.com/SeldonIO/alibi-detect/actions/runs/8808915172 |
This is a follow-up to where the Pydantic v1 shim was added [1]. It's inspired by Ray's approach [2]. This locks the version in the CI and I think that's okay since we don't need to keep on updating them, as they're intended as smoke tests. [1] #882 (comment) [2] ray-project/ray#40451
jesse-c
force-pushed
the
add-test-for-pydantic-v1-v2-explicitly
branch
from
d41a221 to
d7c6abb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to where the Pydantic v1 shim was added [1]. It's inspired by Ray's approach [2].
This locks the version in the CI and I think that's okay since we don't need to keep on updating them, as they're intended as smoke tests.
[1] #882 (comment)
[2] ray-project/ray#40451