Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Support livenessProbe for the nodes in the Helm Chart #1895

Closed
brunobritorj opened this issue Jul 17, 2023 · 2 comments · Fixed by #1897
Closed

[🚀 Feature]: Support livenessProbe for the nodes in the Helm Chart #1895

brunobritorj opened this issue Jul 17, 2023 · 2 comments · Fixed by #1897

Comments

@brunobritorj
Copy link
Contributor

brunobritorj commented Jul 17, 2023

Feature and motivation

Currently, there is only livenessProbe option in the Helm Chart values for the router and hub components, there is no way to add the probe to chromeNode, firefoxNode, and edgeNode.

Usage example

Currently, common properties such as imageName, annotations, labels, resources, ports are supported and placed into the first level in each node. So, the values.yaml file could be adapted to support livenessProbe:

chromeNode:
  (...)
  livenessProbe: {}
firefoxNode:
  (...)
  livenessProbe: {}
edgeNode:
  (...)
  livenessProbe: {}
@github-actions
Copy link

@brunobritorj, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

brunobritorj added a commit to brunobritorj/docker-selenium that referenced this issue Jul 17, 2023
In the Helm Chart, there was no ```livenessProbe``` support for option
```chromeNode```, ```firefoxNode```, and ```edgeNode```.

This commit adds these three Helm Chart values:
- ```chromeNode.livenessProbe: {}```
- ```firefoxNode.livenessProbe {}```
- ```chromeNode.livenessProbe: {}```

The bellow properties will end up in the pod livenessProbe for the
respective node pod.

Fixes SeleniumHQ#1895
brunobritorj added a commit to brunobritorj/docker-selenium that referenced this issue Jul 17, 2023
In the Helm Chart, there was no ```livenessProbe``` support for option
```chromeNode```, ```firefoxNode```, and ```edgeNode```.

This commit adds these three Helm Chart values:
- ```chromeNode.livenessProbe: {}```
- ```firefoxNode.livenessProbe {}```
- ```edgeNode.livenessProbe: {}```

The bellow properties will end up in the pod livenessProbe for the
respective node pod.

Fixes SeleniumHQ#1895
brunobritorj added a commit to brunobritorj/docker-selenium that referenced this issue Jul 17, 2023
In the Helm Chart, there was no ```livenessProbe``` support for option
```chromeNode```, ```firefoxNode```, and ```edgeNode```.

This commit adds these three Helm Chart values:
- ```chromeNode.livenessProbe: {}```
- ```firefoxNode.livenessProbe {}```
- ```edgeNode.livenessProbe: {}```

The bellow properties will end up in the pod livenessProbe for the
respective node pod.

Fixes SeleniumHQ#1895
diemol added a commit that referenced this issue Aug 1, 2023
In the Helm Chart, there was no ```livenessProbe``` support for option
```chromeNode```, ```firefoxNode```, and ```edgeNode```.

This commit adds these three Helm Chart values:
- ```chromeNode.livenessProbe: {}```
- ```firefoxNode.livenessProbe {}```
- ```edgeNode.livenessProbe: {}```

The bellow properties will end up in the pod livenessProbe for the
respective node pod.

Fixes #1895

Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
Copy link

github-actions bot commented Dec 9, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants