Support to nodes livenessProbe into the Helm Chart #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Helm Chart, there was no ```livenessProbe``` support for option
```chromeNode```, ```firefoxNode```, and ```edgeNode```.
This commit adds these three Helm Chart values:
- ```chromeNode.livenessProbe: {}```
- ```firefoxNode.livenessProbe {}```
- ```edgeNode.livenessProbe: {}```
The bellow properties will end up in the pod livenessProbe for the
respective node pod.
Fixes SeleniumHQ#1895
|
|
diemol
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1895
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This commit adds these three Helm Chart values:
chromeNode.livenessProbe: {}firefoxNode.livenessProbe {}edgeNode.livenessProbe: {}The bellow properties will end up in the
livenessProbefor therespective node pod.
Motivation and Context
Currently, there is only
livenessProbeoption in the Helm Chart values for therouterandhubpods, there is no way to add the probe tochromeNode,firefoxNode, andedgeNode.Types of changes
Checklist