Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting driver and browser path via configuration #2017

Merged
merged 10 commits into from
Nov 22, 2023
Merged

Conversation

diemol
Copy link
Member

@diemol diemol commented Nov 21, 2023

  • Setting the service driver and avoid using Selenium Manager
  • Removing the HTTP client one, as Java 11 is the default now.

A downside of this PR, which we need to see how to fix, is that when using a different user ID to run the Firefox containers, the session creation fails with "Could not start a new session. Response code 500. Message: Failed to read marionette port".

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Setting the service driver and avoid using Selenium Manager
- Removing the HTTP client one, as Java 11 is the default now.
@diemol diemol linked an issue Nov 21, 2023 that may be closed by this pull request
@diemol diemol changed the title Using properties for... Setting driver and browser path via configuration Nov 22, 2023
@diemol diemol merged commit ad0a7a6 into trunk Nov 22, 2023
7 checks passed
@diemol diemol deleted the property-service-path branch November 22, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Specify driver location to avoid Selenium Manager
1 participant