Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update NodeChrome support latest version from GoogleChromeLabs #2018

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Nov 22, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

  1. GoogleChromeLabs support a dashboard for versions https://googlechromelabs.github.io/chrome-for-testing
    NodeChrome image can get Chrome version based on ARG CHROME_VERSION with below inputs
       LATEST_RELEASE_STABLE
       LATEST_RELEASE_BETA
       LATEST_RELEASE_DEV
       LATEST_RELEASE_CANARY
       121 (e.g specific major version)
       119.0.6045.105 (e.g specific full version)

By default, ARG CHROME_DRIVER_VERSION follows CHROME_VERSION. Chrome Driver version can be specified independently with the same support inputs above.

  1. Add feat [🚀 Feature]: Specify driver location to avoid Selenium Manager #2008
    [Reverted as duplicate with Setting driver and browser path via configuration #2017]

  2. After setting java prop -Dwebdriver.chrome.driver for NodeChrome. The below issue could be seen always.
    Note: If removing this prop in the command start node, the issue is over, still not figure out reason for this strange

selenium.common.exceptions.SessionNotCreatedException: Message: Could not start a new session. Could not start a new session. Error while creating session with the driver service. Stopping driver service: Could not start a new session. Response code 500. Message: session not created: Chrome failed to start: exited normally.
  (session not created: DevToolsActivePort file doesn't exist)
  (The process started from chrome location /opt/google/chrome/chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.) 

Updated
The above issue can be fixed by adding to node stereotype with the binary location, get from #2017
{"browserName": "chrome", "browserVersion": "119.0", "platformName": "Linux", "goog:chromeOptions": {"binary": "/usr/bin/google-chrome"}}
Change in test has been reverted.

  1. Add test for helm chart, which covers feat(chart): Add chart parameter ingress.paths to configure custom paths #1994

  2. Fix Firefox WebDriver issue when run with random user (true) [🐛 Bug]: Could not start a new session. Response code 500. Message: Failed to read marionette port #2020. Add back test case in workflow

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@VietND96

This comment has been minimized.

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VietND96!

Feature 2 is not needed as we want to set the browser driver always.

Point 3 has been fixed by setting the browser path in the stereotype.

NodeBase/start-selenium-node.sh Outdated Show resolved Hide resolved
NodeBase/start-selenium-node.sh Outdated Show resolved Hide resolved
NodeDocker/start-selenium-grid-docker.sh Outdated Show resolved Hide resolved
NodeDocker/start-selenium-grid-docker.sh Outdated Show resolved Hide resolved
NodeEdge/Dockerfile Outdated Show resolved Hide resolved
NodeFirefox/Dockerfile Outdated Show resolved Hide resolved
NodeFirefox/Dockerfile Outdated Show resolved Hide resolved
Standalone/start-selenium-standalone.sh Outdated Show resolved Hide resolved
Standalone/start-selenium-standalone.sh Outdated Show resolved Hide resolved
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 requested a review from diemol November 23, 2023 11:54
@VietND96
Copy link
Member Author

Thanks for your review @diemol !
I have reverted feat 2, keeping it the same as #2017 only.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VietND96!

@diemol diemol merged commit 82603e9 into SeleniumHQ:trunk Nov 27, 2023
5 checks passed
@VietND96 VietND96 deleted the test-chart branch November 27, 2023 12:01
VietND96 added a commit to NDViet/docker-selenium that referenced this pull request Nov 28, 2023
…HQ#2018

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
VietND96 added a commit that referenced this pull request Nov 29, 2023
…omponent (#2030)

* test: Sanity tests Selenium Grid chart via Makefile commands

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

* Remove redundant if: statement from workflow [skip ci]

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

* Add event workflow_dispatch to release charts [skip ci]

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

* test: Sanity tests Selenium Grid chart via Makefile commands

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

* Increase nginx ingress timeout

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

* feat: distribution registry can be set global and individual component

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

* feat: distribution registry can be set global and individual component

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

* Update chart values.yaml

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

* Update for Released notes to extract Chrome version after PR #2018

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>

---------

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 changed the title Update NodeChrome support latest version from GoogleChromeLabs feat: Update NodeChrome support latest version from GoogleChromeLabs Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Could not start a new session. Response code 500. Message: Failed to read marionette port
3 participants