-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update NodeChrome support latest version from GoogleChromeLabs #2018
Conversation
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @VietND96!
Feature 2 is not needed as we want to set the browser driver always.
Point 3 has been fixed by setting the browser path in the stereotype.
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @VietND96!
…HQ#2018 Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
…omponent (#2030) * test: Sanity tests Selenium Grid chart via Makefile commands Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Remove redundant if: statement from workflow [skip ci] Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Add event workflow_dispatch to release charts [skip ci] Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * test: Sanity tests Selenium Grid chart via Makefile commands Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Increase nginx ingress timeout Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * feat: distribution registry can be set global and individual component Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * feat: distribution registry can be set global and individual component Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update chart values.yaml Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> * Update for Released notes to extract Chrome version after PR #2018 Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com> --------- Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
NodeChrome image can get Chrome version based on ARG
CHROME_VERSION
with below inputsBy default, ARG
CHROME_DRIVER_VERSION
followsCHROME_VERSION
. Chrome Driver version can be specified independently with the same support inputs above.Add feat [🚀 Feature]: Specify driver location to avoid Selenium Manager #2008
[Reverted as duplicate with Setting driver and browser path via configuration #2017]
After setting java prop
-Dwebdriver.chrome.driver
for NodeChrome. The below issue could be seen always.Note: If removing this prop in the command start node, the issue is over, still not figure out reason for this strange
Updated
The above issue can be fixed by adding to node stereotype with the binary location, get from #2017
{"browserName": "chrome", "browserVersion": "119.0", "platformName": "Linux", "goog:chromeOptions": {"binary": "/usr/bin/google-chrome"}}
Change in test has been reverted.
Add test for helm chart, which covers feat(chart): Add chart parameter ingress.paths to configure custom paths #1994
Fix Firefox WebDriver issue when run with random user (true) [🐛 Bug]: Could not start a new session. Response code 500. Message: Failed to read marionette port #2020. Add back test case in workflow
Types of changes
Checklist