Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): distribution registry can be set global and individual component #2030

Merged
merged 9 commits into from
Nov 29, 2023

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Nov 28, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

feat(chart): distribution registry can be set global and individual component

Motivation and Context

  1. Currently, image registry is set static value selenium/, it means the image will be pulled from the Selenium repo on Docker Hub. However, some organizations are hosting their private mirror repo, artifactory to reduce the internet connection reach, moreover, Docker Hub also has their rate limit. Also for different purposes, user is able to set registry for all or individual component
    It would be better chart has a config for the image registry at global and could be overridden in individual components if needed. When deploying a chart, config can be set
    helm upgrade -i RELEASENAME --set global.seleniumGrid.imageRegistry=artifactiory.mydomain.com/selenium --set chromeNode.imageRegistry=nexus-repo.mydomain.com/selenium [--set ...] selenium-grid

  2. Update sanity tests for chart (cont test(chart): Sanity tests Selenium Grid chart via Makefile commands #2029 )

  3. Remove redundant if statement in workflow

  4. Update for released notes to extract Chrome version after PR feat: Update NodeChrome support latest version from GoogleChromeLabs #2018 properly

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 requested a review from diemol November 28, 2023 17:15
@VietND96 VietND96 self-assigned this Nov 28, 2023
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
…HQ#2018

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge, thank you!

@VietND96 VietND96 merged commit 7545bc9 into SeleniumHQ:trunk Nov 29, 2023
5 checks passed
@VietND96 VietND96 deleted the test-chart branch November 29, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Regression: imageName variable not working properly in Helm chart v0.25.1+
2 participants