Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python bindings: Unhelpful error message given when PhantomJS exits unexpectedly #2168

Closed
gtzampanakis opened this issue May 26, 2016 · 0 comments
Closed

Python bindings: Unhelpful error message given when PhantomJS exits unexpectedly #2168

gtzampanakis opened this issue May 26, 2016 · 0 comments

Comments

@gtzampanakis
Copy link
Contributor

gtzampanakis commented May 26, 2016 •
edited
Loading

Meta -

OS: Any
Selenium Version: 2.53.2
Browser: PhantomJS 2.1.1

Expected Behavior -

Prior to checking connectivity to the PhantomJS process Selenium should check that the process is still running.

Actual Behavior -

Selenium does not check that the PhantomJS process is running prior to checking connectivity. This results in unhelpful error message when the subprocess unexpectedly exits. (In my case it exited due to missing shared libs on the testing server but the error message led me to believe that the issue was inability to open a port).

Steps to reproduce -

Replace the PhantomJS executable with a script that exits immediately. Selenium will make 30 tries to connect to it and finally exit with error: "Can not connect to the Service xxx", with xxx being the actual executable path.
gtzampanakis pushed a commit to gtzampanakis/selenium that referenced this issue May 27, 2016
Fixed: Unhelpful error message when PhantomJS exits.
027cafd 
Selenium does not check that the PhantomJS process is running prior to
checking connectivity. This results in unhelpful error message when the
subprocess unexpectedly exits.

The solution is to assert that the process is still running before
connectivity is checked.

Fixes SeleniumHQ#2168.
@gtzampanakis gtzampanakis mentioned this issue May 27, 2016
Merged
1 task
lukeis pushed a commit that referenced this issue May 27, 2016
@gtzampanakis @lukeis
Fixed: Unhelpful error message when PhantomJS exits. (#2173)
051c8b1 
Selenium does not check that the PhantomJS process is running prior to
checking connectivity. This results in unhelpful error message when the
subprocess unexpectedly exits.

The solution is to assert that the process is still running before
connectivity is checked.

Fixes #2168.
AutomatedTester pushed a commit that referenced this issue Jun 3, 2016
@gtzampanakis @AutomatedTester
Fixed: Unhelpful error message when PhantomJS exits. (#2173)
f9c5ff8 
Selenium does not check that the PhantomJS process is running prior to
checking connectivity. This results in unhelpful error message when the
subprocess unexpectedly exits.

The solution is to assert that the process is still running before
connectivity is checked.

Fixes #2168.
@lock lock bot locked and limited conversation to collaborators Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gtzampanakis