Fixed: Unhelpful error message when PhantomJS exits. #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Selenium does not check that the PhantomJS process is running prior to checking connectivity. This results in unhelpful error message when the subprocess unexpectedly exits. The solution is to assert that the process is still running before connectivity is checked. Fixes SeleniumHQ#2168.
AutomatedTester
pushed a commit
that referenced
this pull request
Jun 3, 2016
Selenium does not check that the PhantomJS process is running prior to checking connectivity. This results in unhelpful error message when the subprocess unexpectedly exits. The solution is to assert that the process is still running before connectivity is checked. Fixes #2168.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xin the preceding checkbox, I verify that I have signed the Contributor License AgreementSelenium does not check that the PhantomJS process is running prior to
checking connectivity. This results in unhelpful error message when the
subprocess unexpectedly exits.
The solution is to assert that the process is still running before
connectivity is checked.
Fixes #2168.