-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] Add convenience for enabling BiDi #14029
Conversation
PR Review 🔍
|
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @pujagani!
User description
Related to #13991
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Add a method to enable BiDi
Motivation and Context
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
enableBiDi
method toChromiumOptions
andFirefoxOptions
to simplify enabling BiDi by setting thewebSocketUrl
capability.BiDiSessionCleanUpTest
to use the newenableBiDi
method.Browser
class to use the newenableBiDi
method.Changes walkthrough 📝
ChromiumOptions.java
Add `enableBiDi` method to ChromiumOptions
java/src/org/openqa/selenium/chromium/ChromiumOptions.java
enableBiDi
method to set thewebSocketUrl
capability.FirefoxOptions.java
Add `enableBiDi` method to FirefoxOptions
java/src/org/openqa/selenium/firefox/FirefoxOptions.java
enableBiDi
method to set thewebSocketUrl
capability.BiDiSessionCleanUpTest.java
Use `enableBiDi` method in BiDiSessionCleanUpTest
java/test/org/openqa/selenium/bidi/BiDiSessionCleanUpTest.java
enableBiDi
method in tests.Browser.java
Use `enableBiDi` method in Browser configurations
java/test/org/openqa/selenium/testing/drivers/Browser.java
enableBiDi
method in browserconfigurations.