[java] Add convenience for enabling BiDi (SeleniumHQ#14029)

Related to SeleniumHQ#13991
sandeepsuryaprasad · Oct 29, 2024 · a136c3e · a136c3e
1 parent 0f58725
commit a136c3e
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/java/src/org/openqa/selenium/chromium/ChromiumOptions.java b/java/src/org/openqa/selenium/chromium/ChromiumOptions.java
@@ -186,6 +186,11 @@ public T addEncodedExtensions(List<String> encoded) {
     return (T) this;
   }
 
+  public T enableBiDi() {
+    setCapability("webSocketUrl", true);
+    return (T) this;
+  }
+
   /**
    * Sets an experimental option. Useful for new ChromeDriver options not yet exposed through the
    * {@link ChromiumOptions} API.

diff --git a/java/src/org/openqa/selenium/firefox/FirefoxOptions.java b/java/src/org/openqa/selenium/firefox/FirefoxOptions.java
@@ -294,6 +294,11 @@ private FirefoxOptions setFirefoxOption(String key, Object value) {
     return this;
   }
 
+  public FirefoxOptions enableBiDi() {
+    setCapability("webSocketUrl", true);
+    return this;
+  }
+
   @Override
   protected Set<String> getExtraCapabilityNames() {
     Set<String> names = new TreeSet<>();

diff --git a/java/test/org/openqa/selenium/bidi/BiDiSessionCleanUpTest.java b/java/test/org/openqa/selenium/bidi/BiDiSessionCleanUpTest.java
@@ -36,7 +36,7 @@ class BiDiSessionCleanUpTest {
   void shouldNotCloseBiDiSessionIfOneWindowIsClosed() {
     FirefoxOptions options = (FirefoxOptions) Browser.FIREFOX.getCapabilities();
     // Enable BiDi
-    options.setCapability("webSocketUrl", true);
+    options.enableBiDi();
 
     driver = new FirefoxDriver(options);
 
@@ -64,7 +64,7 @@ void shouldNotCloseBiDiSessionIfOneWindowIsClosed() {
   void shouldCloseBiDiSessionIfLastWindowIsClosed() {
     FirefoxOptions options = (FirefoxOptions) Browser.FIREFOX.getCapabilities();
     // Enable BiDi
-    options.setCapability("webSocketUrl", true);
+    options.enableBiDi();
 
     driver = new FirefoxDriver(options);
 

diff --git a/java/test/org/openqa/selenium/testing/drivers/Browser.java b/java/test/org/openqa/selenium/testing/drivers/Browser.java
@@ -59,7 +59,7 @@ public Capabilities getCapabilities() {
       prefs.put("exited_cleanly", true);
       options.setExperimentalOption("prefs", prefs);
 
-      options.setCapability("webSocketUrl", true);
+      options.enableBiDi();
 
       return options;
     }
@@ -90,7 +90,7 @@ public Capabilities getCapabilities() {
       prefs.put("exited_cleanly", true);
       options.setExperimentalOption("prefs", prefs);
 
-      options.setCapability("webSocketUrl", true);
+      options.enableBiDi();
 
       return options;
     }
@@ -129,7 +129,7 @@ public Capabilities getCapabilities() {
         options.addArguments("-headless");
       }
 
-      options.setCapability("webSocketUrl", true);
+      options.enableBiDi();
 
       return options;
     }