Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update less-rails dependency restriction #38

Closed
brendon opened this issue Oct 1, 2017 · 20 comments · Fixed by #49
Closed

Update less-rails dependency restriction #38

brendon opened this issue Oct 1, 2017 · 20 comments · Fixed by #49

Comments

@brendon
Copy link
Collaborator

brendon commented Oct 1, 2017

less-rails has finally released version 3.0.0 which includes a fix for the Sprockets 3 deprecations warning: metaskills/less-rails#137

Can you update the dependency restriction to be ~> 3.0?

@cisolarix
Copy link

looking forward to this

@brendon
Copy link
Collaborator Author

brendon commented Oct 27, 2017

We're just working on a change to less-rails again that removes reliance on grease and tilt altogether. I've also tested this with Semantic-UI-Less-Rails and it works well with only a couple of changes needed.

Relates to: #40, #39 and metaskills/less-rails#144

@stevenspiel
Copy link

any update on this?

@brendon
Copy link
Collaborator Author

brendon commented Jan 23, 2018

Still waiting on the PR for less-rails to be merged. Our initial attempt was less than successful.

Once @simi merges that fix, I'll be able to do a PR for this repo as there are a couple of changes needed to support the new version.

@birthdaycorp
Copy link

Any update on this?

@brendon
Copy link
Collaborator Author

brendon commented Jul 4, 2018

I got in touch with @simi who is travelling at present. He said he'd try to get on to it soon :) Hopefully he can merge my less-rails PR and then I can do a PR for this repo with a few fixes that are required for it to function well with less-rails. It's been a long time coming, but hopefully things will be sorted soon.

@birthdaycorp
Copy link

if anyone else is looking to get the most recent version of Semantic UI and less-rails working without having to rely on this gem, check out this answer on stackoverflow.

@brendon
Copy link
Collaborator Author

brendon commented Jul 4, 2018

Complicated though hey? :)

@simi
Copy link

simi commented Jul 5, 2018 via email

@brendon
Copy link
Collaborator Author

brendon commented Jul 5, 2018

Will do.

@brendon
Copy link
Collaborator Author

brendon commented Jul 16, 2018

Hi @simi, just pinging you again :)

@daveharris
Copy link

@simi is there any progress to report on this?

@brendon
Copy link
Collaborator Author

brendon commented Jul 25, 2018

Just a reminder: this: metaskills/less-rails#144 needs to be merged before we look into updating the dependency here. Looks like someone updated the travis.yml to add Ruby 2.5 testing so I've just updated my PR to check it's all green still. @simi, if you want to make me a maintainer I'd be more than happy to help maintain these two gems.

@birthdaycorp
Copy link

hi @simi! can you please make someone else a maintainer? you clearly need the help, and @brendon has volunteered to fix the Sprockets dependency. we all have a need for this gem, so if you could please?

@brendon
Copy link
Collaborator Author

brendon commented Aug 23, 2018

Yep @simi, I'm more than happy to step in. I'll also need rights to publish the gems too.

@simi
Copy link

simi commented Aug 23, 2018

I can't add contributors and right to publish gems to less-rails. Anyway I'm happy to help you preparing new release and send it to rubygems.

note: sorry for late response :/

@brendon
Copy link
Collaborator Author

brendon commented Aug 24, 2018

Hi everyone. @simi has released 4.0.0.rc1. Can you all test this release out with your code and let us know if there are any problems. See the changelog for one potentially breaking change.

@brendon
Copy link
Collaborator Author

brendon commented Aug 24, 2018

I'm referring to the less-rails gem in the above comment.

@birthdaycorp
Copy link

Everything looks good!

@brendon
Copy link
Collaborator Author

brendon commented Aug 26, 2018

#49 Fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants