Solve Sprockets DEPRECATION WARNING #137

brendon · 2017-05-29T02:18:34Z

I’m using Grease https://github.com/yasaichi/grease as a wrapper around
LessTemplate and ImportProcessor and have also rejigged the loading
process to make things compatible with Sprockets 2, 3 and 4.

Extra changes:

Turned the warnings off for now with rake to make the output of the
tests a bit more understandable.
Update the README with regards to getting the test suite running
Fixed a couple of spec’s to look for the right engine and
preprocessor classes
Removed the use of capture in run_generator. There is no
recommended replacement.

Closes: #122 Finally! :)

Thanks to #128 for inspiration @MustafaZain.

I’m using Grease https://github.com/yasaichi/grease as a wrapper around `LessTemplate` and `ImportProcessor` and have also rejigged the loading process to make things compatible with Sprockets 2, 3 and 4. Extra changes: * Turned the warnings off for now with rake to make the output of the tests a bit more understandable. * Update the `README` with regards to getting the test suite running * Fixed a couple of spec’s to look for the right engine and preprocessor classes * Removed the use of `capture` in `run_generator`. There is no recommended replacement.

brendon · 2017-05-29T03:48:33Z

@simi, finally the test suite seems to be in order! Let me know if you need any more information about this. I think there's a large group of people hanging out for this fix :D

tdonia · 2017-05-31T20:27:24Z

this works for us (thank you, @brendon!) -- almost -- on Rails 5.0 because it eliminates Sprockets.register_engine '.less', LessTemplate in railties in this commit: brendon@f573927#diff-998c29126ad83cee99c229f1d43307b5L16

the one additional issue that we hit is the line above:

Sprockets::Engines #force autoloading errs with
block in <class:Railtie>': uninitialized constant Sprockets::Engines (NameError)

I don’t think Sprockets::Engines is required to be called explicitly to autoload.

brendon · 2017-05-31T21:32:54Z

Thanks for the feedback @tdonia :) I've pushed a change that should hopefully fix that. Let me know how it works on your end. I'll see how travis likes it also.

Use `register_transformer` instead of `register_preprocessor`.

`rails s` still yield the deprecation warning: * See issue: metaskills/less-rails#122 * PR pending: metaskills/less-rails#137 * Workaround: `gem 'less-rails', github: 'brendon/less-rails', branch: 'fix-sprockets-loading'

ali-anwar · 2017-07-26T05:04:22Z

Any update on this? Thank you.

simi · 2017-07-26T09:10:29Z

README.md

-$ bundle install
-$ bundle exec rake appraisal:setup
-$ bundle exec rake appraisal test
+$ bundle


please keep bundle install here

I can do that, but bundle is the same as bundle install (install is the default action). Let me know if you still want it changed back.

Anyone alive?

I can confirm that I am alive.

simi · 2017-07-26T09:10:37Z

Rakefile

@@ -7,6 +7,7 @@ Rake::TestTask.new do |t|
  t.libs = ['lib','test']
  t.test_files = Dir.glob("test/**/*_spec.rb").sort
  t.verbose = true
+  t.warning = false


Can you remove this change?

Will do. I think it was to silence the errors from some other dependencies (therubyracer) and make the test results more rational to view.

simi · 2017-07-26T09:11:42Z

.travis.yml

-  - 2.0.0
-  - 2.1.4
-  - jruby-19mode
+  - 2.2.7


Do we need to drop old rubies here? Are they failing?

Off the top of my head I can't remember. Depending on the rails version, we'd have to exclude certain combinations. I can add them back to the matrix and see how they test out if you like?

Fuzzy matching doesn’t seem to work properly with RVM

This could be fixed by moving away from therubyracer in the future.

brendon · 2017-07-26T22:36:06Z

Hi @simi, I've updated the test matrix and all the tests pass. I'm only testing for the latest version of jruby. Is that ok?

I've commented out the warnings line. It's handy to have there locally to uncomment because of the excessive therubyracer warnings. We should migrate away from that perhaps in another PR since I think the Rails team did the same.

I'll wait to hear from you on the bundle vs bundle install thing.

brendon · 2017-07-31T21:47:47Z

Hi @simi, any more comments before we finalise this? :)

Rails did this transition already. Either library will work, but we should go with what is current. It also removes the warnings showing up in the tests.

drn · 2017-08-25T03:08:23Z

@simi Can we get this merged in? We just upgraded sprockets / rails and are running into these warnings. Happy to help make any changes, but it looks like the changes have been made and we're just waiting on a merge + release.

ubugnu · 2017-09-08T22:24:53Z

I've used the workaround:
gem 'less-rails', github: 'brendon/less-rails', branch: 'fix-sprockets-loading'
On rails 5. But less files are no longer compiled (I get a 'not found' myscript.less.css)
The same configuration works with the default gem.
Any idea on how to fix the problem?

brendon · 2017-09-10T20:45:42Z

Hi @ubugnu, thanks for reporting the error. If .less.css is a usual extension then the problem is that it wasn't added as a valid extension for Sprockets 3 that requires all extensions to be explicitly defined.

I've added the .less.css extension in there for now. Give it a try. Can others chime in on whether .less.css is a usual extension for less files in Rails?

brendon · 2017-10-01T22:43:55Z

100,000 🎉 :D

brendon · 2017-10-01T22:45:49Z

Can you ping when the gem is released? :)

simi · 2017-10-01T23:03:26Z

First of all I'm really sorry for being the break at this deprecation removal problem.

I would like to thanks all involved in this, mainly @brendon for crafting this PR and @drn for friendly email ping.

This is included in fresh 3.0 release.

See metaskills/less-rails#137 and #102. Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>

The warning is: ``` DEPRECATION WARNING: Sprockets method `register_engine` is deprecated. Please register a mime type using `register_mime_type` then use `register_compressor` or `register_transformer`. ``` This problem is really a less-rails error, and is documented in this issue of that repo: metaskills/less-rails#122 It was fixed with this PR, merged Oct 2017: metaskills/less-rails#137 Bumping our less-rails dependency to 3.0.0 will give us the updates in that PR. Version 3.0.0 is the next version after 2.8.0, so there are very few other changes to worry about. You can view all of the less-rails code changes between 2.8.0 and 3.0.0 here: metaskills/less-rails@05186eb...7bb14e5 They are almost all test and/or README changes. So this update should be low risk.

`rails s` still yield the deprecation warning: * See issue: metaskills/less-rails#122 * PR pending: metaskills/less-rails#137 * Workaround: `gem 'less-rails', github: 'brendon/less-rails', branch: 'fix-sprockets-loading'

brendon mentioned this pull request May 29, 2017

deprecation warning at 'rails s' #122

Closed

brendon added 4 commits May 29, 2017 15:19

Attempt a more up to date travis environment

76920dd

Attempt to get appraisal recognised on the command line

c8a1d01

Travis will run for all the gemfiles

ea10564

Allow the gemfiles to be in git

a10821a

Rails 4.0 and 4.1 don't work on Ruby 2.4.1

597c585

Require at the head of the file

1af4a21

I don’t think Sprockets::Engines is required to be called explicitly to autoload.

Register .less.erb as a text/less mime type

704326e

Use `register_transformer` instead of `register_preprocessor`.

simi requested changes Jul 26, 2017

View reviewed changes

brendon added 3 commits July 27, 2017 09:51

Update the text matrix

fa3c5b2

Be more precise about ruby version numbers

a41bc80

Fuzzy matching doesn’t seem to work properly with RVM

Don't silence warnings anymore

0dfd540

This could be fixed by moving away from therubyracer in the future.

wvengen mentioned this pull request Aug 4, 2017

Fix deprecation warnings foodcoops/foodsoft#470

Open

2 tasks

pierre mentioned this pull request Aug 4, 2017

Fix tests and runtime warnings killbill/killbill-admin-ui#102

Closed

2 tasks

brendon added 2 commits August 5, 2017 21:48

Use mini_racer instead of therubyracer

9de9c21

Rails did this transition already. Either library will work, but we should go with what is current. It also removes the warnings showing up in the tests.

Never mind, the less gem depends on therubyracer

edb63de

Add .less.css as an extension

7b47171

simi approved these changes Oct 1, 2017

View reviewed changes

simi merged commit 2b623f6 into metaskills:master Oct 1, 2017

brendon mentioned this pull request Oct 1, 2017

Update less-rails dependency restriction Semantic-Org/Semantic-UI-Rails-LESS#38

Closed

pierre added a commit to killbill/killbill-admin-ui that referenced this pull request Oct 2, 2017

gemspec: bump less-rails dependency

92c16e9

See metaskills/less-rails#137 and #102. Signed-off-by: Pierre-Alexandre Meyer <pierre@mouraf.org>

brendon deleted the fix-sprockets-loading branch October 12, 2017 07:24

davidlaprade mentioned this pull request Feb 20, 2018

Bump less-rails to remove deprecation warnings, fixes #925 seyhunak/twitter-bootstrap-rails#930

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Solve Sprockets DEPRECATION WARNING #137

Solve Sprockets DEPRECATION WARNING #137

brendon commented May 29, 2017

brendon commented May 29, 2017

tdonia commented May 31, 2017

brendon commented May 31, 2017

ali-anwar commented Jul 26, 2017

simi Jul 26, 2017

brendon Jul 26, 2017

darthrevan Sep 14, 2017

brendon Sep 14, 2017

simi Jul 26, 2017

brendon Jul 26, 2017 •

edited

Loading

simi Jul 26, 2017

brendon Jul 26, 2017

brendon commented Jul 26, 2017

brendon commented Jul 31, 2017

drn commented Aug 25, 2017 •

edited

Loading

ubugnu commented Sep 8, 2017 •

edited

Loading

brendon commented Sep 10, 2017

brendon commented Oct 1, 2017

brendon commented Oct 1, 2017

simi commented Oct 1, 2017 •

edited

Loading

Solve Sprockets DEPRECATION WARNING #137

Solve Sprockets DEPRECATION WARNING #137

Conversation

brendon commented May 29, 2017

brendon commented May 29, 2017

tdonia commented May 31, 2017

brendon commented May 31, 2017

ali-anwar commented Jul 26, 2017

simi Jul 26, 2017

Choose a reason for hiding this comment

brendon Jul 26, 2017

Choose a reason for hiding this comment

darthrevan Sep 14, 2017

Choose a reason for hiding this comment

brendon Sep 14, 2017

Choose a reason for hiding this comment

simi Jul 26, 2017

Choose a reason for hiding this comment

brendon Jul 26, 2017 • edited Loading

Choose a reason for hiding this comment

simi Jul 26, 2017

Choose a reason for hiding this comment

brendon Jul 26, 2017

Choose a reason for hiding this comment

brendon commented Jul 26, 2017

brendon commented Jul 31, 2017

drn commented Aug 25, 2017 • edited Loading

ubugnu commented Sep 8, 2017 • edited Loading

brendon commented Sep 10, 2017

brendon commented Oct 1, 2017

brendon commented Oct 1, 2017

simi commented Oct 1, 2017 • edited Loading

brendon Jul 26, 2017 •

edited

Loading

drn commented Aug 25, 2017 •

edited

Loading

ubugnu commented Sep 8, 2017 •

edited

Loading

simi commented Oct 1, 2017 •

edited

Loading