Form onSubmit should accept HTMLFormElement event #2500
Comments
|
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
|
Agreed, thanks! |
corydeppen
added a commit
to corydeppen/Semantic-UI-React
that referenced
this issue
Feb 6, 2018
levithomason
pushed a commit
that referenced
this issue
Feb 6, 2018
Brantron
pushed a commit
to Brantron/Semantic-UI-React
that referenced
this issue
Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's not a bug, but rather a request to change the TS definition for the
eventparameter foronSubmitfromReact.FormEvent<HTMLElement>toReact.FormEvent<HTMLFormElement>in theFormcomponent. This seems more appropriate and will allow it to handle events from other libraries like Formik without a compilation error. I don't mind submitting the PR to make this quick change if there is agreement.The text was updated successfully, but these errors were encountered: