Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept HTMLFormElement form event #2501

Merged
merged 1 commit into from
Feb 6, 2018
Merged

Accept HTMLFormElement form event #2501

merged 1 commit into from
Feb 6, 2018

Conversation

corydeppen
Copy link
Contributor

Fixes #2500

@levithomason levithomason merged commit 6a1794a into Semantic-Org:master Feb 6, 2018
@welcome
Copy link

welcome bot commented Feb 6, 2018

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@corydeppen corydeppen deleted the patch-2 branch February 6, 2018 23:49
@levithomason
Copy link
Member

Released in semantic-ui-react@0.78.2.

/cc @corydeppen

@polc
Copy link

polc commented Feb 24, 2018

Hello, should not the event type be : React.SyntheticEvent<HTMLFormElement> ? compile with react-final-form. Here is the function type in popular libraries :

Brantron pushed a commit to Brantron/Semantic-UI-React that referenced this pull request Mar 14, 2018
@corydeppen
Accept HTMLFormElement form event (Semantic-Org#2501)
3f540a6 
Fixes Semantic-Org#2500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corydeppen @levithomason @polc