fix(Menu): fix typings for Menu.Item

[shanehyde]

The typings are missing a correct definition for onClick on Menu.Item to add the props as the 2nd parameter.

The typings for Button are correct, so this is a copy of the onClick definition from there for Menu.Item

[codecov-io]

Current coverage is 95.89% (diff: 100%)

Merging #1235 into master will not change coverage

@@             master      #1235   diff @@
==========================================
  Files           880        880          
  Lines          4901       4901          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           4700       4700          
  Misses          201        201          
  Partials          0          0          

Powered by Codecov. Last update d3b1acd...c4734e1

[squirly]

there should be space between data?: and MenuItemProps

[layershifter]

data will be always passed.

-onClick?: (event: React.MouseEvent<HTMLElement>, data?:MenuItemProps) => void;
+onClick?: (event: React.MouseEvent<HTMLElement>, data: MenuItemProps) => void;

[shanehyde]

I have made both those changes and added them to the PR

[levithomason]

Released in semantic-ui-react@0.64.5.

[tilor]

Menu.Item throws a compiler error in 0.64.5 (this error did not happen in 0.64.0):

error TS2430: Interface 'MenuItemProps' incorrectly extends interface 'ReactMouseEvents'.
Types of property 'onClick' are incompatible.
Type '(event: MouseEvent, data: MenuItemProps) => void' is not assignable to type 'EventHandler<MouseEvent>'.

[dylankiss]

I get the same error when using 0.64.5.

[levithomason]

@layershifter ?

[layershifter]

I've forget to make a response there, it was fixed in #1264.