Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Menu): fix typings for Menu.Item #1235

Merged
merged 2 commits into from
Jan 28, 2017
Merged

fix(Menu): fix typings for Menu.Item #1235

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6479864
Fix typings for Menu.Item onClink Handler
shanehyde Jan 27, 2017
c4734e1
Fix spacing and make data non-optional
shanehyde Jan 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/collections/Menu/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,13 @@ interface MenuItemProps extends ReactMouseEvents<HTMLElement> {
/** Internal name of the MenuItem. */
name?: string;

/**
* Called after user's click.
* @param {SyntheticEvent} event - React's original SyntheticEvent.
* @param {object} data - All props.
*/
onClick?: (event: React.MouseEvent<HTMLElement>, data?:MenuItemProps) => void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be space between data?: and MenuItemProps

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data will be always passed.

-onClick?: (event: React.MouseEvent<HTMLElement>, data?:MenuItemProps) => void;
+onClick?: (event: React.MouseEvent<HTMLElement>, data: MenuItemProps) => void;


/** A menu item can take right position. */
position?: 'right';
}
Expand Down