Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added docs on Indexing events #300

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Added docs on Indexing events #300

merged 3 commits into from
Jul 21, 2023

Conversation

nikcio
Copy link
Contributor

@nikcio nikcio commented Oct 13, 2022

Adds to #191

Also added a XML comment to the LuceneIndex.IndexCommitted event

@nikcio nikcio changed the title Added some more information on Indexing events Added docs on Indexing events Oct 13, 2022
@Shazwazza Shazwazza added the hacktoberfest-accepted Part Hacktoberfest label Oct 28, 2022
Shazwazza
Shazwazza requested changes Nov 29, 2022
View reviewed changes
Copy link
Owner

@Shazwazza Shazwazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Have left a couple comments

docs/indexing.md Outdated Show resolved Hide resolved
docs/indexing.md Outdated Show resolved Hide resolved
@nikcio
Copy link
Contributor Author

nikcio commented Nov 30, 2022

@Shazwazza Should be fixed now 😄

@nikcio nikcio force-pushed the docs/indexing-events branch from 75a58b4 to c0c264e Compare June 18, 2023 11:41
@nikcio
Copy link
Contributor Author

nikcio commented Jun 18, 2023

@Shazwazza I've updated the docs changes to the new docfx from #322 so it's ready to merge now. It's been a while since this PR was created so I'll just refresh what's going on:

  • This PR adds code examples of how you can listen to indexing events.

@nikcio nikcio requested a review from Shazwazza June 18, 2023 11:44
@nikcio
Copy link
Contributor Author

nikcio commented Jul 21, 2023

Hey @Shazwazza can i do anything to move this PR forward? 😁

@Shazwazza
Copy link
Owner

@nikcio Thanks so much for all your effort :)

@Shazwazza Shazwazza merged commit e3cec96 into Shazwazza:release/3.0 Jul 21, 2023
@Shazwazza
Copy link
Owner

I'll see if i can cherry pick this to the feature/docfx branch since that is where the docs are published from

Shazwazza
Shazwazza reviewed Jul 21, 2023
View reviewed changes
docs/indexing.md
@@ -142,7 +142,9 @@ Data is easily deleted from the index by the unique identifier you provided in y

<!-- Tabs -->
<div class="container">
<input type="radio" id="tab-link-20" name="docwriting" checked />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc doesn't merge with the feature/docfx branch where the docs now live so this wasn't cherry picked. For doc updates now, They'll have to be done against feature/docfx for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fine the other file will be the one that will come on the docfx site😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shazwazza Shazwazza Shazwazza requested changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Part Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikcio @Shazwazza