-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workspaces support #1778
Workspaces support #1778
Conversation
Thanks for your contribution! Depending on what you are working on, you may want to request a review from a Shopify team:
|
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
Coverage report
Show files with reduced coverage 🔻
Test suite run success1148 tests passing in 561 suites. Report generated by 🧪jest coverage report action from 89e67d3 |
ae7f794
to
86226dd
Compare
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. |
This reverts commit fa6502d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with this one!
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/node-package-manager.d.ts@@ -170,6 +170,11 @@ export interface PackageJson {
* The prettier attribute of the package.json
*/
prettier?: string;
+ /**
+ * The private attribute of the package.json.
+ * https://docs.npmjs.com/cli/v9/configuring-npm/package-json#private
+ */
+ private?: boolean;
}
/**
* Reads and parses a package.json
|
WHAT is this pull request doing?
Related to https://github.com/Shopify/internal-cli-foundations/issues/311
dev
andbuild
if the app doesn't support workspaces yet.How to test your changes?
dev
you shouldn't see the "Installing dependencies" messagedev
orbuild
in a non-workspace app, you should see a warning message.Post-release steps
Release https://github.com/Shopify/shopify-dev/pull/33782
Measuring impact
How do we know this change was effective? Please choose one:
Checklist
dev
ordeploy
have been reflected in the internal flowchart.