Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] Fix dev for Ruby apps #4523

Closed

Conversation

gonzaloriestra
Copy link
Contributor

Cherrypick commits from #4522

Copy link
Contributor

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

Copy link
Contributor

github-actions bot commented Sep 25, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
73.02% (-0.08% 🔻)
8392/11493
🟡 Branches
69.6% (-0.01% 🔻)
4095/5884
🟡 Functions
71.75% (-0.12% 🔻)
2179/3037
🟡 Lines
73.36% (-0.08% 🔻)
7941/10824
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / marketing_activity.ts
25% (-75% 🔻)
100%
0% (-100% 🔻)
25% (-75% 🔻)
🟢
... / context.ts
91.67% (-0.03% 🔻)
87.28% 88.57%
92.62% (-0.03% 🔻)
🟢
... / conf-store.ts
100%
90.24% (-2.44% 🔻)
100% 100%
🟡
... / session.ts
76.92% (-1.34% 🔻)
64.77% (-2.25% 🔻)
90% (-1.67% 🔻)
77.17% (-1.19% 🔻)
🟡
... / exchange.ts
75.44% (-7.89% 🔻)
77.78%
80% (-10% 🔻)
75% (-8.05% 🔻)
🟡
... / output.ts
77.39% (-0.19% 🔻)
76.19% (+0.81% 🔼)
63.64%
77.06% (-0.21% 🔻)
🟢
... / session.ts
82.86% (-0.48% 🔻)
83.87% 71.43%
81.82% (-0.53% 🔻)

Test suite run success

1890 tests passing in 857 suites.

Report generated by 🧪jest coverage report action from 07c4623

Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/version.d.ts
@@ -1 +1 @@
-export declare const CLI_KIT_VERSION = "3.67.0";
\ No newline at end of file
+export declare const CLI_KIT_VERSION = "3.67.1";
\ No newline at end of file

@MitchDickinson
Copy link
Contributor

I think something went wrong with the cherrypicking here? Why are there so many files? Either way, I dont think we should ship this per my comments on #4522

@gonzaloriestra gonzaloriestra changed the base branch from main to stable/3.67 September 25, 2024 14:41
@gonzaloriestra
Copy link
Contributor Author

Sorry, I had chosen the wrong base branch.

@gonzaloriestra
Copy link
Contributor Author

Closing in favor of #4527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants