Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Price range inputs in filter drawer do not handle comma separated values #2981

Closed
kmeleta opened this issue Aug 30, 2023 · 1 comment · Fixed by AshEastham-idhl/dawn#3
Closed

Price range inputs in filter drawer do not handle comma separated values #2981

kmeleta opened this issue Aug 30, 2023 · 1 comment · Fixed by AshEastham-idhl/dawn#3
Labels
Category: Bug Something isn't working

Comments

@kmeleta
Copy link
Contributor

kmeleta commented Aug 30, 2023 •
edited
Loading

When filtering products by price, the range inputs in the filter drawer don't handle comma separated currencies properly, when using prices about 1000.

This is similar to issues raised in #255, but this issue is scoped to the drawer filters type, which is also displayed on mobile.

Possible solution

Including the same use_commas_decimals logic within mobile-facets markup in facets.liquid appears to correct the issue (see internal issue for specifics)
@kmeleta kmeleta added the Category: Bug Something isn't working label Aug 30, 2023
@kmeleta
Copy link
Contributor Author

kmeleta commented Aug 30, 2023

Possible fix #2980

@AshEastham-idhl AshEastham-idhl mentioned this issue Sep 11, 2023
Merged
9 tasks
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this issue Sep 3, 2024
@Roi-Arthur
Add liquid to assign uses_comma_decimals on mobile (Shopify#2980)
9df03e5 
Fixes Shopify#2981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add liquid to assign uses_comma_decimals on mobile (#2980) Shopify/dawn
1 participant
@kmeleta