Add liquid to assign uses_comma_decimals on mobile #2980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Adding a liquid check bring mobile facets filters to parity with desktop filters. In their current state they break (at least visually) when using a currency that uses commas as decimal separator.
Another small addition is the removal of the Turkish Lyra (TRY) from the list of such currencies, as Turkish Lyra does not in fact use a comma for decimals.
Edit: This is already being requested here
Why are these changes introduced?
Fixes #0.
What approach did you take?
Duplicated the existing liquid block that can be found around line 305 of the facets.liquid file and added it under the second instance of
{% when 'price_range' %}
I debated adding the check further up to have it in the code only once but this approach ensures we only run that check when there is a price range filter.
Other considerations
Visual impact on existing themes
No impact other than fixing value of filters inputs
Testing steps/scenarios
Demo links
Uploading Drawer input max error fix.mp4…
Checklist