-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
animate Featured collection, Related products and Product grid sections #2372
Conversation
f6f0f4b
to
6ee24e0
Compare
36d0d9e
to
108dc5b
Compare
bf50ae9
to
815055b
Compare
This works really well, and the JS solution feels way more elegant than all the Just noting that @metamoni and I chatted earlier and determined that it's ok for V1 to just fade/slide-in the entire Related Products section at once (rather than in a cascade, like other product grids). During initial prototypes, there were some issues around getting this section to animate correctly. I'm seeing some related bugginess here — if you scroll too quickly into the Related Products section, you get a little jump before the related products appear. Here's a slow-motion video to demonstrate. This isn't related to our work here, but it's a little more obvious because all the other animations are incredibly smooth. 😅 If we think there's an easy fix for this, let's do it! Otherwise we can look into it later and I don't consider it a blocker. |
229e09d
to
502064e
Compare
815055b
to
0a2fb26
Compare
7bc7879
to
4637192
Compare
3456e44
to
c7dc625
Compare
4637192
to
0489839
Compare
52edc83
to
0e01a72
Compare
5d2744e
to
2949e34
Compare
3c5b4ca
to
32a3758
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working nicely for me — haven't stumbled upon any broken parts. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very minor comment, but this looks good to me! 🎉
* add animation to Image banner and Image with text
4235ec7
to
298c35f
Compare
* shopify/main: Fix empty space in the drawer when there are no social media icons / account / localizations (Shopify#2425) Update 1 translation file (Shopify#2479) animate Featured collection, Related products and Product grid sections (Shopify#2372) Update 1 translation file (Shopify#2474) Update 1 translation file (Shopify#2473)
…ns (Shopify#2372) animate Featured Collection, Product grid, Related products
PR Summary:
Makes Featured collection, Related products and Product grid fade in on scroll.
Why are these changes introduced?
Fixes #2318
Decision log
--animation-order
andanimation-delay
properties to create cascading animationnth-child
approach from prototypeVisual impact on existing themes
Once this PR is merged, the Featured collection, Related products and Product grid sections will scroll into view if the
Reveal on scroll
setting is enabled in Theme Settings > Animations.Featured collection
featured.collection.scroll.into.view.mp4
Product grid
product.grid.mp4
Related products
related-products.mp4
Testing steps/scenarios
Featured collection - Default product grid view (title and description slide in, products cascade in)
Featured collection - Desktop and mobile carousel (title, description and container slide in, products do not cascade in)
Product grid and related items
Reduce motion
in your OS and verify that the animations stop workingDemo links
Checklist