Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate Featured Blog and Collection List sections #2522

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

kjellr
Copy link
Contributor

@kjellr kjellr commented Apr 13, 2023

PR Summary:

Adds cascading fade in on scroll animation to the Blog Posts and Collection List sections.

Why are these changes introduced?

Closes #2389.

What approach did you take?

Replicated animations from the #2141

Visual impact on existing themes

desktop.mp4
mobile.mp4

Testing steps/scenarios

  1. Ensure "Reveal sections on scroll" is set within Theme Settings > Animation.
  2. Add Collection List section, ensure it smoothly animates in on scroll.
  3. Add Featured Blog section, ensure it smoothly animates in on scroll.
  4. Adjust settings, ensure animation continues working as expected.
  5. Specifically check that the mobile slider functions as usual.

Demo links

Checklist

Copy link
Contributor

@ludoboludo ludoboludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@kjellr kjellr merged commit f7eaac1 into main Apr 14, 2023
@kjellr kjellr deleted the animate-blog-posts-collection-list branch April 14, 2023 12:28
phapsidesGT pushed a commit to Gravytrain-UK/gt-shopify-dawn-theme that referenced this pull request Sep 3, 2024
* Animate Collection List

* Animate Featured Blog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Blog posts] and [Collection list]: Add cascading fade in on scroll animation
3 participants