Quick Order List + Volume Pricing #2791
Conversation
![translation-platform[bot]](https://avatars.githubusercontent.com/in/7649?s=60&v=4){kind=small}
| @@ -330,6 +337,27 @@ | |||
| }, | |||
| "page": { | |||
| "title": "Page title" | |||
| }, | |||
| "quick_order_list": { | |||
| "product_total": "Product subtotal", | |||
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Product subtotalfor keysections.quick_order_list.product_totalis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| }, | ||
| "quick_order_list": { | ||
| "product_total": "Product subtotal", | ||
| "view_cart": "View cart", |
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
View cartfor keysections.quick_order_list.view_cartis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| "name": "Quick order list", | ||
| "settings": { | ||
| "show_image": { | ||
| "label": "Show images" |
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Show imagesfor keysections.quick-order-list.settings.show_image.labelis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| "label": "Show images" | ||
| }, | ||
| "show_sku": { | ||
| "label": "Show SKUs" |
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Show SKUsfor keysections.quick-order-list.settings.show_sku.labelis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| @@ -330,6 +337,27 @@ | |||
| }, | |||
| "page": { | |||
| "title": "Page title" | |||
| }, | |||
| "quick_order_list": { | |||
| "product_total": "Product subtotal", | |||
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Product subtotalfor keysections.quick_order_list.product_totalis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| }, | ||
| "quick_order_list": { | ||
| "product_total": "Product subtotal", | ||
| "view_cart": "View cart", |
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
View cartfor keysections.quick_order_list.view_cartis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
| "name": "Quick order list", | ||
| "settings": { | ||
| "show_image": { | ||
| "label": "Show images" |
There was a problem hiding this comment.
Localization quality issue found
The following issues may affect the quality of localized translations if they are not addressed:
- The value
Show imagesfor keysections.quick-order-list.settings.show_image.labelis very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
Please look out for other instances of this issue in your PR and fix them as well if possible.
Questions about these messages? Hop in the #help-localization Slack channel.
sofiamatulis
force-pushed
the
variantlist-volpricing
branch
from
294f9c3 to
7f498ad
Compare
|
We'll need to do more testing with global styles in general after merging, but for now wanted to flag that some of the volume pricing popover buttons will inherit global button border styles. We can wait to fix in 
|
|
Everything's looking really good!
+1 to @KaichenWang's comment on testing Global styles— let's wait to address those in |
Fixed ^ https://screenshot.click/13-35-krmv1-84bik.png |
|
Bug: Variant list add to cart breaks if you click it 2 short bursts. Repro steps: Suggested solution: Block quantity changes when loading the same way we do in cart. breaking-add-to-cart-variant-list.mp4 |
Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
sofiamatulis
force-pushed
the
variantlist-volpricing
branch
from
16d516e to
6b09409
Compare
|
Is this feature demoed anywhere on the actual dawn demo store |
|
Hey @PaulNewton Quick order list and volume pricing are in the current version of Dawn now. To see them you should be logged in as a B2B customer. In order to see volume-pricing you need to browse the website via preview and not the editor. |
|
@eugenekasimov private instances are moot and come with their own baggage for public demos. The theme store specifically notes the quick-order-list as a headlining feature in the changelog for v11. People on the outside considering shopify or discussing theme capabilities cannot validate the growing list of claimed features in shopify's own feature-lists without jumping through unnecessary hoops. |
This PR introduces Volume Pricing and Quick Order List
Quick order List: a new Bulk Buying Section available for the PDP. Designs can be found here: https://www.figma.com/file/3y5RP5ET0JvqORkRFpyWmH/Variants-List-Design-Review?type=design&node-id=0-1&t=ursrFVPa2NlGVTkC-0
Volume Pricing available to buyers logged in with b2b on feat prod, product page and cart. Designs: https://www.figma.com/file/AxH2jkpnLbZXPR8NbgaoaK/Volume-pricing-in-flagship-themes?type=design&node-id=2-130&t=4TqjzhFcoEMyh2av-0
Here are the PRs that were merged here (there are also some other PRs that were merged in the below PRs as well):
Editor: https://os2-demo.myshopify.com/admin/themes/140237864982/editor