Add price per item to Quick Order List #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofiamatulis
commented
Jul 7, 2023
| @@ -299,3 +364,17 @@ | |||
| {% # theme-check-enable %} | |||
| </td> | |||
| </tr> | |||
|
|
|||
| <volume-pricing class="hidden" id="Volume-{{ variant.id }}"> | |||
There was a problem hiding this comment.
To get the volume pricing, I had to create a hidden volume pricing element to access it and make it hidden
But maybe we can look into an API later
sofiamatulis
commented
Jul 7, 2023
| {%- liquid | ||
| assign volume_pricing_array = variant.quantity_price_breaks | sort: 'price' | ||
| -%} | ||
| <price-per-item |
There was a problem hiding this comment.
Thoughts on making this a snippet?
There was a problem hiding this comment.
Eventually we will do it but maybe in a quieter time?
KaichenWang
reviewed
Jul 7, 2023
KaichenWang
reviewed
Jul 7, 2023
sofiamatulis
force-pushed
the
variantlist-price
branch
2 times, most recently
from
fe762a3 to
b909e43
Compare
Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
sofiamatulis
force-pushed
the
variantlist-price
branch
from
901c49e to
aff4c08
Compare
|
Don't think this was introduced in this PR, but adding to cart and then adjusting quantity in Quick order list causes an error. I checked and it seems on cart update, the HTML in the DOM for Quick order errors is replaced with the same element, but with an incorrect id. Quickest fix was just to move the element in Liquid - #2798 screencast.2023-07-07.17-20-11.mp4 |
KaichenWang
approved these changes
Jul 7, 2023
* Add variant list price * Fix price logic * Change min to step after rebase * Update assets/variant-list.js Co-authored-by: Kai <KaichenWang@users.noreply.github.com> * Update assets/component-volume-pricing.css Co-authored-by: Kai <KaichenWang@users.noreply.github.com> * Update assets/price-per-item.js Co-authored-by: Kai <KaichenWang@users.noreply.github.com> * Add missing part after rebase --------- Co-authored-by: Sofia Matulis <sofia.matulis@shopify.com> Co-authored-by: Kai <KaichenWang@users.noreply.github.com>
This was referenced Jul 10, 2023
sofiamatulis
added a commit
that referenced
this pull request
Jul 13, 2023
KaichenWang
pushed a commit
that referenced
this pull request
Jul 14, 2023
KaichenWang
pushed a commit
that referenced
this pull request
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
Add variant list price change to the variant List section when there is volume pricing
Approach
I am re-using the price per item from Vol Pricing. I had to make some changes to ensure it works for variant list
Demo links
Editor