Skip to content
This repository has been archived by the owner on Mar 19, 2022. It is now read-only.

Pre compute the timestamp range for feature views #49

Closed
wants to merge 11 commits into from
Closed

Pre compute the timestamp range for feature views #49

wants to merge 11 commits into from

Conversation

tpvasconcelos
Copy link
Contributor

This PR tackles the backward-incompatible changes introduced in feast-dev/feast#2103.

It is required to make feast-trino compatible with feast ~ v0.17.*, where entity_df_timestamp_range was introduced as a required argument to the feast.infra.offline_stores.get_feature_view_query_context(...) function.

Please see the PR referenced above for more context and for reference implementations.

@tpvasconcelos tpvasconcelos requested a review from a team as a code owner March 7, 2022 22:52
@tpvasconcelos
Copy link
Contributor Author

Bumped the (minor) version to 1.1.0 and upgraded the feast dependency to 0.17.*

Comment on lines -28 to -29
/opt/hostedtoolcache/Python
/Users/runner/hostedtoolcache/Python
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what these two were doing here but these paths were messing up with the installation of python requirements. I left only the path to pip's cache as per:

@olivierlabreche
Copy link
Contributor

Hi @tpvasconcelos!
Thanks for this contribution. We are in the process of migrating this repo to the main feast code base, see open PR: feast-dev/feast#2414
I will close this as we are going to archive this repo. However, feel free to contribute to the migration by adding this to the PR as this fix will definitely be needed before we can merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants