Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre compute the timestamp range for feature views #2103

Merged
merged 5 commits into from
Dec 21, 2021

Conversation

judahrand
Copy link
Member

@judahrand judahrand commented Dec 3, 2021

What this PR does / why we need it:
This allows BigQuery to take advantage of Partitions when querying
historical features.

Which issue(s) this PR fixes:

Fixes #2083 (doesn't necessarily completely fix but does fix in at least one case)

Does this PR introduce a user-facing change?:

None

@feast-ci-bot
Copy link
Collaborator

Hi @judahrand. Thanks for your PR.

I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2021

Codecov Report

Merging #2103 (11a695f) into master (5560caf) will decrease coverage by 0.15%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2103      +/-   ##
==========================================
- Coverage   57.88%   57.73%   -0.16%     
==========================================
  Files         101      101              
  Lines        8176     8205      +29     
==========================================
+ Hits         4733     4737       +4     
- Misses       3443     3468      +25     
Flag Coverage Δ
unittests 57.73% <33.33%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/local.py 92.85% <ø> (+5.62%) ⬆️
sdk/python/feast/infra/offline_stores/bigquery.py 31.35% <13.33%> (-1.79%) ⬇️
sdk/python/feast/infra/offline_stores/redshift.py 38.57% <20.00%> (-2.70%) ⬇️
...python/feast/infra/offline_stores/offline_utils.py 44.55% <50.00%> (-0.13%) ⬇️
sdk/python/feast/utils.py 90.00% <75.00%> (-10.00%) ⬇️
sdk/python/feast/infra/online_stores/sqlite.py 95.50% <100.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5560caf...11a695f. Read the comment docs.

@judahrand judahrand force-pushed the bq-partition branch 5 times, most recently from 89cd59a to b5a8d26 Compare December 3, 2021 13:55
@judahrand judahrand force-pushed the bq-partition branch 7 times, most recently from 488afd5 to caaa839 Compare December 16, 2021 11:06
@judahrand
Copy link
Member Author

I believe this is functional but it is so hard to tell will how flakey the AWS tests are 😢 Even just what seems like random connection errors.

@pyalex
Copy link
Collaborator

pyalex commented Dec 17, 2021

/lgtm

This allows BigQuery to take advantage of Partitions when querying
historical features.

Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
@judahrand
Copy link
Member Author

@pyalex Could we get this merged once the tests run. I keep having to merge in conflicts from master. Not sure why the docker build is failing?

@judahrand
Copy link
Member Author

@pyalex all good here

Copy link
Member

@achals achals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: achals, judahrand, pyalex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does BigQuery template query take advantage of Partitions?
6 participants