-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre compute the timestamp range for feature views #2103
Conversation
Hi @judahrand. Thanks for your PR. I'm waiting for a feast-dev member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
eb75ce9
to
76a64b8
Compare
Codecov Report
@@ Coverage Diff @@
## master #2103 +/- ##
==========================================
- Coverage 57.88% 57.73% -0.16%
==========================================
Files 101 101
Lines 8176 8205 +29
==========================================
+ Hits 4733 4737 +4
- Misses 3443 3468 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
89cd59a
to
b5a8d26
Compare
488afd5
to
caaa839
Compare
I believe this is functional but it is so hard to tell will how flakey the AWS tests are 😢 Even just what seems like random connection errors. |
/lgtm |
This allows BigQuery to take advantage of Partitions when querying historical features. Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
Signed-off-by: Judah Rand <17158624+judahrand@users.noreply.github.com>
caaa839
to
3d8a471
Compare
@pyalex Could we get this merged once the tests run. I keep having to merge in conflicts from |
@pyalex all good here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: achals, judahrand, pyalex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This allows BigQuery to take advantage of Partitions when querying
historical features.
Which issue(s) this PR fixes:
Fixes #2083 (doesn't necessarily completely fix but does fix in at least one case)
Does this PR introduce a user-facing change?: