Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1.15.12 of k8s when starting minikube #766

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Conversation

nishanthooda
Copy link

@nishanthooda nishanthooda commented Nov 19, 2020

What are you trying to accomplish with this PR?

  • dev up was failing, so bumping to with Kubernetes 1.11.10 is not supported by this release of minikube
  • this pr bumps the version to 1.15.xx

What could go wrong?

  • bumping the version has some other unintended effects

cc @Shopify/pipeline

dev.yml Outdated Show resolved Hide resolved
@nishanthooda nishanthooda changed the title Use v1.13.0 of k8s when starting minikube Use v1.15.xx of k8s when starting minikube Nov 20, 2020
Copy link
Contributor

@dturn dturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change and then this will be ready to ship.

dev.yml Outdated Show resolved Hide resolved
@nishanthooda nishanthooda changed the title Use v1.15.xx of k8s when starting minikube Use v1.15.12 of k8s when starting minikube Nov 23, 2020
RyanBrushett
RyanBrushett previously approved these changes Nov 23, 2020
@dturn dturn merged commit 7fe2593 into master Nov 23, 2020
@dturn dturn deleted the bump-minikube-kube-version branch November 23, 2020 21:43
@esnunes esnunes mentioned this pull request Dec 14, 2020
@dturn dturn temporarily deployed to rubygems December 14, 2020 16:54 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants