Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use v1.15.12 of k8s when starting minikube #766

Merged
merged 2 commits into from
Nov 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions .buildkite/pipeline.nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,31 +13,3 @@ steps:
env:
LOGGING_LEVEL: 4
KUBERNETES_VERSION: v1.15-latest
- name: 'Run Test Suite (:kubernetes: 1.14-latest)'
command: bin/ci
agents:
queue: k8s-ci
env:
LOGGING_LEVEL: 4
KUBERNETES_VERSION: v1.14-latest
- name: 'Run Test Suite (:kubernetes: 1.13-latest)'
command: bin/ci
agents:
queue: k8s-ci
env:
LOGGING_LEVEL: 4
KUBERNETES_VERSION: v1.13-latest
- name: 'Run Test Suite (:kubernetes: 1.12-latest)'
command: bin/ci
agents:
queue: k8s-ci
env:
LOGGING_LEVEL: 4
KUBERNETES_VERSION: v1.12-latest
- name: 'Run Test Suite (:kubernetes: 1.11-latest)'
command: bin/ci
agents:
queue: k8s-ci
env:
LOGGING_LEVEL: 4
KUBERNETES_VERSION: v1.11-latest
28 changes: 0 additions & 28 deletions .shopify-build/krane.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,31 +38,3 @@ steps:
env:
LOGGING_LEVEL: "4"
KUBERNETES_VERSION: v1.15-latest
- label: 'Run Test Suite (:kubernetes: 1.14-latest)'
command: bin/ci
agents:
queue: k8s-ci
env:
LOGGING_LEVEL: "4"
KUBERNETES_VERSION: v1.14-latest
- label: 'Run Test Suite (:kubernetes: 1.13-latest)'
command: bin/ci
agents:
queue: k8s-ci
env:
LOGGING_LEVEL: "4"
KUBERNETES_VERSION: v1.13-latest
- label: 'Run Test Suite (:kubernetes: 1.12-latest)'
command: bin/ci
agents:
queue: k8s-ci
env:
LOGGING_LEVEL: "4"
KUBERNETES_VERSION: v1.12-latest
- label: 'Run Test Suite (:kubernetes: 1.11-latest)'
command: bin/ci
agents:
queue: k8s-ci
env:
LOGGING_LEVEL: "4"
KUBERNETES_VERSION: v1.11-latest
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## next

- Kubernetes 1.14 and lower is no longer officially supported as of this version ([#766](https://github.com/Shopify/krane/pull/766))

## 2.1.2

- Add version exception for FrontendConfig (GKE resource) [#761](https://github.com/Shopify/krane/pull/761)
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ If you need the ability to render dynamic values in templates before deploying,
## Prerequisites

* Ruby 2.5+
* Your cluster must be running Kubernetes v1.11.0 or higher<sup>1</sup>
* Your cluster must be running Kubernetes v1.15.0 or higher<sup>1</sup>

<sup>1</sup> We run integration tests against these Kubernetes versions. You can find our
official compatibility chart below.
Expand All @@ -90,7 +90,7 @@ official compatibility chart below.

## Installation

1. [Install kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-kubectl-binary-via-curl) (requires v1.11.0 or higher) and make sure it is available in your $PATH
1. [Install kubectl](https://kubernetes.io/docs/tasks/tools/install-kubectl/#install-kubectl-binary-via-curl) (requires v1.15.0 or higher) and make sure it is available in your $PATH
2. Set up your [kubeconfig file](https://kubernetes.io/docs/tasks/access-application-cluster/authenticate-across-clusters-kubeconfig/) for access to your cluster(s).
3. `gem install krane`

Expand Down Expand Up @@ -493,7 +493,7 @@ resource to restart.

## Prerequisites

* You've already deployed a [`PodTemplate`](https://v1-10.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#podtemplate-v1-core) object with field `template` containing a `Pod` specification that does not include the `apiVersion` or `kind` parameters. An example is provided in this repo in `test/fixtures/hello-cloud/template-runner.yml`.
* You've already deployed a [`PodTemplate`](https://v1-15.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.15/#podtemplate-v1-core) object with field `template` containing a `Pod` specification that does not include the `apiVersion` or `kind` parameters. An example is provided in this repo in `test/fixtures/hello-cloud/template-runner.yml`.
* The `Pod` specification in that template has a container named `task-runner`.

Based on this specification `krane run` will create a new pod with the entrypoint of the `task-runner ` container overridden with the supplied arguments.
Expand Down
4 changes: 2 additions & 2 deletions bin/setup
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ if [ ! -x "$(which minikube)" ]; then
fi

if [ ! -x "$(which kubectl)" ]; then
echo -e "\n\033[0;33mPlease install kubectl version 1.11.0 or higher:\nhttps://kubernetes.io/docs/user-guide/prereqs/\033[0m"
echo -e "\n\033[0;33mPlease install kubectl version 1.15.0 or higher:\nhttps://kubernetes.io/docs/user-guide/prereqs/\033[0m"
else
KUBECTL_VERSION=$(kubectl version --short --client | grep -oe "v[[:digit:]\.]\+")
echo -e "\n\033[0;32mKubectl version $KUBECTL_VERSION is already installed. This gem requires version v1.11.0 or greater.\033[0m"
echo -e "\n\033[0;32mKubectl version $KUBECTL_VERSION is already installed. This gem requires version v1.15.0 or greater.\033[0m"
fi
2 changes: 1 addition & 1 deletion dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ up:
- custom:
name: Minikube Cluster
met?: test $(minikube status | grep Running | wc -l) -ge 2 && $(minikube status | grep -q 'Configured')
meet: minikube start --kubernetes-version=v1.11.10 --vm-driver=hyperkit
meet: minikube start --kubernetes-version=v1.15.12 --vm-driver=hyperkit
down: minikube stop
commands:
reset-minikube: minikube delete && rm -rf ~/.minikube
Expand Down
2 changes: 1 addition & 1 deletion lib/krane/common.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,5 @@
require 'krane/task_config_validator'

module Krane
MIN_KUBE_VERSION = '1.11.0'
MIN_KUBE_VERSION = '1.15.0'
end