Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Collapsible] Remove deprecated Collapsible argument #7397

Merged
merged 2 commits into from
Oct 31, 2022
Merged

[Collapsible] Remove deprecated Collapsible argument #7397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c384560
Remove deprecated collapsible property
Bringer128 Oct 13, 2022
ab2618a
Changeset description
Bringer128 Oct 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stupid-vans-kick.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': major
---

Removed deprecated preventMeasuringOnChildUpdate prop on Collapsible
3 changes: 0 additions & 3 deletions polaris-react/src/components/Collapsible/Collapsible.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ export interface CollapsibleProps {
* @default transition={{duration: 'var(--p-duration-150)', timingFunction: 'var(--p-ease-in-out)'}}
*/
transition?: boolean | Transition;
/** @deprecated Re-measuring is no longer necessary on children update **/
preventMeasuringOnChildrenUpdate?: boolean;
/** The content to display inside the collapsible. */
children?: React.ReactNode;
}
Expand All @@ -35,7 +33,6 @@ export function Collapsible({
expandOnPrint,
open,
transition = true,
preventMeasuringOnChildrenUpdate: _preventMeasuringOnChildrenUpdate,
children,
}: CollapsibleProps) {
const [height, setHeight] = useState(0);
Expand Down