Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Collapsible] Remove deprecated Collapsible argument #7397

Merged
merged 2 commits into from
Oct 31, 2022

Conversation

Bringer128
Copy link
Contributor

WHY are these changes introduced?

Removes a deprecated argument on the Collapsible component with the major version bump.

WHAT is this pull request doing?

Removes the prop as a breaking change.

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

N/A tophatting instructions as Polaris does not use this prop internally.

🎩 checklist

Copy link
Member

@kyledurand kyledurand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
polaris-react-cjs 208.93 KB (-0.01% 🔽)
polaris-react-esm 135.47 KB (-0.01% 🔽)
polaris-react-esnext 190.81 KB (-0.01% 🔽)
polaris-react-css 41.52 KB (0%)

@Bringer128 Bringer128 merged commit d2d396f into v11-major Oct 31, 2022
@Bringer128 Bringer128 deleted the remove_deprecated_collapsible_argument branch October 31, 2022 14:29
sam-b-rose added a commit that referenced this pull request May 26, 2023
## @shopify/polaris v11.0.0

### Dependencies

- [x] #8200

### NodeJS

- [x] #8201

### TypeScript

- [x] #8203

### Components

- [x] #7349
- [x] #7397
- [x] #7962
- [x] #8187
- [x] #8184
- [x] #8206
- [x] #7990
- [x] #8468
- [x] #8577
- [x] #8631
- [x] #8962

## @shopify/polaris-tokens v7.0.0

### Tokens
- [x] #6920
- [x] #8245
- [x] #4826
- [x] #8405

## @shopify/stylelint-polaris v7.0.0
- [x] #7622
- [x] #8419

# Post @shopify/polaris v11 shipping
- [ ] #8420

## Low priority or not ready breaking changes
- [x] Remove deprecated layout components
- [x] Release Layout primitive components

---------

Co-authored-by: Tim Layton <tmlayton@users.noreply.github.com>
Co-authored-by: Ryan Musgrave <ryan.musgrave@shopify.com>
Co-authored-by: Ryan Musgrave <ryanm128@gmail.com>
Co-authored-by: aveline <aveline@users.noreply.github.com>
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
Co-authored-by: Matt Gregg <matt.gregg@shopify.com>
Co-authored-by: Alex Page <hi@alexpage.dev>
Co-authored-by: Lo Kim <lo.kim@shopify.com>
Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com>
Co-authored-by: Sam Rose <sam.rose@shopify.com>
Co-authored-by: Marc Thomas <marc.thomas@shopify.com>
Co-authored-by: Alex Page <19199063+alex-page@users.noreply.github.com>
Co-authored-by: Chloe Rice <18447883+chloerice@users.noreply.github.com>
Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
Co-authored-by: Joe Thomas <joe.thomas@shopify.com>
Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com>
Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
## @shopify/polaris v11.0.0

### Dependencies

- [x] Shopify#8200

### NodeJS

- [x] Shopify#8201

### TypeScript

- [x] Shopify#8203

### Components

- [x] Shopify#7349
- [x] Shopify#7397
- [x] Shopify#7962
- [x] Shopify#8187
- [x] Shopify#8184
- [x] Shopify#8206
- [x] Shopify#7990
- [x] Shopify#8468
- [x] Shopify#8577
- [x] Shopify#8631
- [x] Shopify#8962

## @shopify/polaris-tokens v7.0.0

### Tokens
- [x] Shopify#6920
- [x] Shopify#8245
- [x] Shopify#4826
- [x] Shopify#8405

## @shopify/stylelint-polaris v7.0.0
- [x] Shopify#7622
- [x] Shopify#8419

# Post @shopify/polaris v11 shipping
- [ ] Shopify#8420

## Low priority or not ready breaking changes
- [x] Remove deprecated layout components
- [x] Release Layout primitive components

---------

Co-authored-by: Tim Layton <tmlayton@users.noreply.github.com>
Co-authored-by: Ryan Musgrave <ryan.musgrave@shopify.com>
Co-authored-by: Ryan Musgrave <ryanm128@gmail.com>
Co-authored-by: aveline <aveline@users.noreply.github.com>
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
Co-authored-by: Matt Gregg <matt.gregg@shopify.com>
Co-authored-by: Alex Page <hi@alexpage.dev>
Co-authored-by: Lo Kim <lo.kim@shopify.com>
Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com>
Co-authored-by: Sam Rose <sam.rose@shopify.com>
Co-authored-by: Marc Thomas <marc.thomas@shopify.com>
Co-authored-by: Alex Page <19199063+alex-page@users.noreply.github.com>
Co-authored-by: Chloe Rice <18447883+chloerice@users.noreply.github.com>
Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
Co-authored-by: Joe Thomas <joe.thomas@shopify.com>
Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com>
Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants