Update rollup and babel to latest versions #8200

alex-page · 2023-01-29T22:05:30Z

WHY are these changes introduced?

Rollup and Babel are blocking our migration to minimum NodeJS version 16.

This PR updated all Rollup and Babel dependencies. These NPM package upgrades are not compatible with NodeJS 14.17 (main branch version). This change unblocks a larger change to our NodeJS versions.

WHAT is this pull request doing?

Moves duplicate dependencies to root
Upgrades all rollup and babel dependencies
Fixes any required breaking changes or warnings
Compared diff of previous packages and new ones and it doesn't have a regression

How to 🎩

Run a build on main save the built files on desktop
Run a build on this bump-build-deps save the built files on desktop
Run a diff over the built files
Make sure no regressions
CI, tests should pass and website should render all pages.

@alex-page's output from Diff: diff.zip

diff -bur polaris-tokens/dist-main polaris-tokens/dist-v11 > icons.diff
diff -bur polaris-tokens/dist-main polaris-tokens/dist-v11 > tokens.diff
diff -bur polaris-migrator/dist-main polaris-migrator/dist-v11 > migrator.diff
diff -bur polaris-react/build-main polaris-react/build-v11 > react.diff

🎩 checklist

Tested on mobile
Tested on multiple browsers
Tested for accessibility
Updated the component's README.md with documentation changes
Tophatted documentation changes in the style guide

alex-page · 2023-01-29T22:05:59Z

polaris-migrator/package.json

-    "@rollup/plugin-babel": "^5.3.1",
-    "@rollup/plugin-commonjs": "^22.0.2",
-    "@rollup/plugin-json": "^4.1.0",
-    "@rollup/plugin-node-resolve": "^13.3.0",


Moved to root

github-actions · 2023-01-29T22:24:06Z

size-limit report 📦

Path	Size
polaris-react-cjs	212.06 KB (-1.45% 🔽)
polaris-react-esm	136.31 KB (-0.23% 🔽)
polaris-react-esnext	189.85 KB (-0.18% 🔽)
polaris-react-css	40.63 KB (0%)

alex-page · 2023-01-29T22:25:04Z

polaris-migrator/rollup.config.mjs

@@ -21,14 +21,14 @@ export default {
  output: [
    {
      format: /** @type {const} */ ('cjs'),
-      entryFileNames: '[name][assetExtname].js',


[assetExtname] no longer exists in the latest version of rollup.

Note that in this case, [name] will include the relative path from the output root and possibly the original file extension if it was not one of .js, .jsx, .mjs, .cjs, .ts, .tsx, .mts, or .cts.
https://rollupjs.org/configuration-options/#output-entryfilenames

alex-page · 2023-01-29T22:28:53Z

polaris-icons/rollup.config.mjs

-    manualChunks: (id) => {
-      // Generate distinct chunks for each icon
-      // This allows consuming apps to split up the icons into multiple subchunks
-      // containing a few icons each instead of always having to put every icon
-      // into a single shared chunk
-      if (id.startsWith(iconBasePath)) {
-        return id.replace(iconBasePath, 'icons/');
-      }
-    },


manualChunks is going to move to output in the next breaking change. This moves it now so we don't have to fix it later.

alex-page · 2023-01-30T00:10:55Z

I am going to merge this into v11. Please still take a look/review I will be happy to iterate in a follow up PR.

## @shopify/polaris v11.0.0 ### Dependencies - [x] #8200 ### NodeJS - [x] #8201 ### TypeScript - [x] #8203 ### Components - [x] #7349 - [x] #7397 - [x] #7962 - [x] #8187 - [x] #8184 - [x] #8206 - [x] #7990 - [x] #8468 - [x] #8577 - [x] #8631 - [x] #8962 ## @shopify/polaris-tokens v7.0.0 ### Tokens - [x] #6920 - [x] #8245 - [x] #4826 - [x] #8405 ## @shopify/stylelint-polaris v7.0.0 - [x] #7622 - [x] #8419 # Post @shopify/polaris v11 shipping - [ ] #8420 ## Low priority or not ready breaking changes - [x] Remove deprecated layout components - [x] Release Layout primitive components --------- Co-authored-by: Tim Layton <tmlayton@users.noreply.github.com> Co-authored-by: Ryan Musgrave <ryan.musgrave@shopify.com> Co-authored-by: Ryan Musgrave <ryanm128@gmail.com> Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: Matt Gregg <matt.gregg@shopify.com> Co-authored-by: Alex Page <hi@alexpage.dev> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com> Co-authored-by: Sam Rose <sam.rose@shopify.com> Co-authored-by: Marc Thomas <marc.thomas@shopify.com> Co-authored-by: Alex Page <19199063+alex-page@users.noreply.github.com> Co-authored-by: Chloe Rice <18447883+chloerice@users.noreply.github.com> Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com> Co-authored-by: Joe Thomas <joe.thomas@shopify.com> Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

## @shopify/polaris v11.0.0 ### Dependencies - [x] Shopify#8200 ### NodeJS - [x] Shopify#8201 ### TypeScript - [x] Shopify#8203 ### Components - [x] Shopify#7349 - [x] Shopify#7397 - [x] Shopify#7962 - [x] Shopify#8187 - [x] Shopify#8184 - [x] Shopify#8206 - [x] Shopify#7990 - [x] Shopify#8468 - [x] Shopify#8577 - [x] Shopify#8631 - [x] Shopify#8962 ## @shopify/polaris-tokens v7.0.0 ### Tokens - [x] Shopify#6920 - [x] Shopify#8245 - [x] Shopify#4826 - [x] Shopify#8405 ## @shopify/stylelint-polaris v7.0.0 - [x] Shopify#7622 - [x] Shopify#8419 # Post @shopify/polaris v11 shipping - [ ] Shopify#8420 ## Low priority or not ready breaking changes - [x] Remove deprecated layout components - [x] Release Layout primitive components --------- Co-authored-by: Tim Layton <tmlayton@users.noreply.github.com> Co-authored-by: Ryan Musgrave <ryan.musgrave@shopify.com> Co-authored-by: Ryan Musgrave <ryanm128@gmail.com> Co-authored-by: aveline <aveline@users.noreply.github.com> Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com> Co-authored-by: Matt Gregg <matt.gregg@shopify.com> Co-authored-by: Alex Page <hi@alexpage.dev> Co-authored-by: Lo Kim <lo.kim@shopify.com> Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com> Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com> Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com> Co-authored-by: Sam Rose <sam.rose@shopify.com> Co-authored-by: Marc Thomas <marc.thomas@shopify.com> Co-authored-by: Alex Page <19199063+alex-page@users.noreply.github.com> Co-authored-by: Chloe Rice <18447883+chloerice@users.noreply.github.com> Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com> Co-authored-by: Joe Thomas <joe.thomas@shopify.com> Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com> Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Bump build dependencies

7ff43f4

alex-page commented Jan 29, 2023

View reviewed changes

Merge branch 'v11-major' into bump-build-deps

53b178d

alex-page changed the base branch from main to v11-major January 29, 2023 22:12

alex-page added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Jan 29, 2023

alex-page commented Jan 29, 2023

View reviewed changes

alex-page requested review from aaronccasanova and sam-b-rose and removed request for aaronccasanova January 29, 2023 22:54

alex-page marked this pull request as ready for review January 29, 2023 22:54

alex-page requested review from aaronccasanova, jesstelford and BPScott January 29, 2023 22:54

alex-page changed the title ~~Bump build dependencies~~ 1/x Bump build dependencies Jan 29, 2023

jesstelford approved these changes Jan 29, 2023

View reviewed changes

Merge branch 'v11-major' into bump-build-deps

c890078

alex-page merged commit ff6248c into v11-major Jan 30, 2023

alex-page deleted the bump-build-deps branch January 30, 2023 00:11

alex-page mentioned this pull request Jan 30, 2023

@shopify/polaris v11.0.0 major release #7597

Merged

23 tasks

alex-page changed the title ~~1/x Bump build dependencies~~ Upgraded rollup and babel to latest versions Jan 30, 2023

alex-page changed the title ~~Upgraded rollup and babel to latest versions~~ Update rollup and babel to latest versions Jan 30, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rollup and babel to latest versions #8200

Update rollup and babel to latest versions #8200

alex-page commented Jan 29, 2023 •

edited

Loading

alex-page Jan 29, 2023

github-actions bot commented Jan 29, 2023 •

edited

Loading

alex-page Jan 29, 2023

alex-page Jan 29, 2023 •

edited

Loading

alex-page commented Jan 30, 2023

Update rollup and babel to latest versions #8200

Update rollup and babel to latest versions #8200

Conversation

alex-page commented Jan 29, 2023 • edited Loading

WHY are these changes introduced?

WHAT is this pull request doing?

How to 🎩

🎩 checklist

alex-page Jan 29, 2023

Choose a reason for hiding this comment

github-actions bot commented Jan 29, 2023 • edited Loading

size-limit report 📦

alex-page Jan 29, 2023

Choose a reason for hiding this comment

alex-page Jan 29, 2023 • edited Loading

Choose a reason for hiding this comment

alex-page commented Jan 30, 2023

alex-page commented Jan 29, 2023 •

edited

Loading

github-actions bot commented Jan 29, 2023 •

edited

Loading

alex-page Jan 29, 2023 •

edited

Loading