Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After v11 ships remove deprecated v10 custom properties from stylelint-polaris #8420

Closed
lgriffee opened this issue Feb 17, 2023 · 0 comments · Fixed by #9887
Closed

After v11 ships remove deprecated v10 custom properties from stylelint-polaris #8420

lgriffee opened this issue Feb 17, 2023 · 0 comments · Fixed by #9887
Assignees
@lgriffee

Comments

@lgriffee
Copy link
Member

lgriffee commented Feb 17, 2023 •
edited
Loading

Remove the tokens added in #8419 on the v11 branch.
@lgriffee lgriffee changed the title Remove legacy v11 custom properties from stylelint-polaris Remove deprecated v11 custom properties from stylelint-polaris Feb 17, 2023
@lgriffee lgriffee mentioned this issue Feb 17, 2023
Merged
23 tasks
@lgriffee lgriffee changed the title Remove deprecated v11 custom properties from stylelint-polaris Remove deprecated v10 custom properties from stylelint-polaris Apr 12, 2023
@lgriffee lgriffee mentioned this issue Apr 13, 2023
Merged
@alex-page alex-page changed the title Remove deprecated v10 custom properties from stylelint-polaris After v11 ships remove deprecated v10 custom properties from stylelint-polaris Apr 24, 2023
sam-b-rose added a commit that referenced this issue May 26, 2023
@lgriffee @tmlayton
@Bringer128 @aveline @kyledurand @itwasmattgregg @alex-page @laurkim @BPScott @aaronccasanova @sam-b-rose @mrcthms @chloerice @heyjoethomas @shopify-github-actions-access @github-actions
@shopify/polaris v11.0.0 major release (#7597)
9e1350e 
## @shopify/polaris v11.0.0

### Dependencies

- [x] #8200

### NodeJS

- [x] #8201

### TypeScript

- [x] #8203

### Components

- [x] #7349
- [x] #7397
- [x] #7962
- [x] #8187
- [x] #8184
- [x] #8206
- [x] #7990
- [x] #8468
- [x] #8577
- [x] #8631
- [x] #8962

## @shopify/polaris-tokens v7.0.0

### Tokens
- [x] #6920
- [x] #8245
- [x] #4826
- [x] #8405

## @shopify/stylelint-polaris v7.0.0
- [x] #7622
- [x] #8419

# Post @shopify/polaris v11 shipping
- [ ] #8420

## Low priority or not ready breaking changes
- [x] Remove deprecated layout components
- [x] Release Layout primitive components

---------

Co-authored-by: Tim Layton <tmlayton@users.noreply.github.com>
Co-authored-by: Ryan Musgrave <ryan.musgrave@shopify.com>
Co-authored-by: Ryan Musgrave <ryanm128@gmail.com>
Co-authored-by: aveline <aveline@users.noreply.github.com>
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
Co-authored-by: Matt Gregg <matt.gregg@shopify.com>
Co-authored-by: Alex Page <hi@alexpage.dev>
Co-authored-by: Lo Kim <lo.kim@shopify.com>
Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com>
Co-authored-by: Sam Rose <sam.rose@shopify.com>
Co-authored-by: Marc Thomas <marc.thomas@shopify.com>
Co-authored-by: Alex Page <19199063+alex-page@users.noreply.github.com>
Co-authored-by: Chloe Rice <18447883+chloerice@users.noreply.github.com>
Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
Co-authored-by: Joe Thomas <joe.thomas@shopify.com>
Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com>
Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@lgriffee lgriffee self-assigned this Jun 5, 2023
juzser pushed a commit to juzser/polaris that referenced this issue Jul 27, 2023
@lgriffee @tmlayton
@Bringer128 @aveline @kyledurand @itwasmattgregg @alex-page @laurkim @BPScott @aaronccasanova @sam-b-rose @mrcthms @chloerice @heyjoethomas @shopify-github-actions-access @github-actions @juzser
@shopify/polaris v11.0.0 major release (Shopify#7597)
7201283 
## @shopify/polaris v11.0.0

### Dependencies

- [x] Shopify#8200

### NodeJS

- [x] Shopify#8201

### TypeScript

- [x] Shopify#8203

### Components

- [x] Shopify#7349
- [x] Shopify#7397
- [x] Shopify#7962
- [x] Shopify#8187
- [x] Shopify#8184
- [x] Shopify#8206
- [x] Shopify#7990
- [x] Shopify#8468
- [x] Shopify#8577
- [x] Shopify#8631
- [x] Shopify#8962

## @shopify/polaris-tokens v7.0.0

### Tokens
- [x] Shopify#6920
- [x] Shopify#8245
- [x] Shopify#4826
- [x] Shopify#8405

## @shopify/stylelint-polaris v7.0.0
- [x] Shopify#7622
- [x] Shopify#8419

# Post @shopify/polaris v11 shipping
- [ ] Shopify#8420

## Low priority or not ready breaking changes
- [x] Remove deprecated layout components
- [x] Release Layout primitive components

---------

Co-authored-by: Tim Layton <tmlayton@users.noreply.github.com>
Co-authored-by: Ryan Musgrave <ryan.musgrave@shopify.com>
Co-authored-by: Ryan Musgrave <ryanm128@gmail.com>
Co-authored-by: aveline <aveline@users.noreply.github.com>
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
Co-authored-by: Matt Gregg <matt.gregg@shopify.com>
Co-authored-by: Alex Page <hi@alexpage.dev>
Co-authored-by: Lo Kim <lo.kim@shopify.com>
Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com>
Co-authored-by: Sam Rose <sam.rose@shopify.com>
Co-authored-by: Marc Thomas <marc.thomas@shopify.com>
Co-authored-by: Alex Page <19199063+alex-page@users.noreply.github.com>
Co-authored-by: Chloe Rice <18447883+chloerice@users.noreply.github.com>
Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
Co-authored-by: Joe Thomas <joe.thomas@shopify.com>
Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com>
Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@lgriffee lgriffee mentioned this issue Aug 3, 2023
Merged
lgriffee added a commit that referenced this issue Aug 15, 2023
@lgriffee
Remove deprecated v10 custom properties from stylelint-polaris (#9887)
a3da87e 
### WHY are these changes introduced?

Fixes #8420

### WHAT is this pull request doing?

Removes [these deprecated v10 custom
properties](#8405) from
`stylelint-polaris` which were added in
#8549 and
#9074.
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this issue Apr 22, 2024
@lgriffee
Remove deprecated v10 custom properties from stylelint-polaris (Sho…
eb73c2f 
…pify#9887)

### WHY are these changes introduced?

Fixes Shopify#8420

### WHAT is this pull request doing?

Removes [these deprecated v10 custom
properties](Shopify#8405) from
`stylelint-polaris` which were added in
Shopify#8549 and
Shopify#9074.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lgriffee lgriffee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated v10 custom properties from stylelint-polaris Shopify/polaris
1 participant
@lgriffee