Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new z-index token names #8245

Merged
merged 5 commits into from
Feb 2, 2023
Merged

Add new z-index token names #8245

merged 5 commits into from
Feb 2, 2023

Conversation

lgriffee
Copy link
Member

@lgriffee lgriffee commented Feb 2, 2023

WHY are these changes introduced?

We want to rename these tokens in v11. By adding the new names in v10 we can break up the major version bump into more manageable chunks (we can create and run migrations for the values in v10 and then just remove the values in the launch of v11).

WHAT is this pull request doing?

Adds a set of identical z-index tokens with the names --p-z-index-* (vs. --p-z-*)

@lgriffee lgriffee self-assigned this Feb 2, 2023
@lgriffee lgriffee mentioned this pull request Feb 2, 2023
Closed
alex-page
alex-page approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@alex-page alex-page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @lgriffee

@lgriffee @alex-page
Update .changeset/fuzzy-timers-kneel.md
861f65d 
Co-authored-by: Alex Page <hi@alexpage.dev>
@lgriffee @aaronccasanova
Update .changeset/fuzzy-timers-kneel.md
ed66514 
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
@lgriffee lgriffee merged commit 1b1394d into main Feb 2, 2023
@lgriffee lgriffee deleted the add-new-zindex-names branch February 2, 2023 20:17
@lgriffee lgriffee mentioned this pull request Feb 2, 2023
Merged
23 tasks
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Feb 2, 2023
Merged
sam-b-rose added a commit that referenced this pull request Feb 2, 2023
@sam-b-rose
Merge branch 'main' into v11-major
37cacc5 
* main:
  Disallow text transform in stylelint-polaris coverage rules (#8244)
  Add new z-index token names (#8245)
  Version Packages (#8236)
  [Layout foundations][Batch 3] Rebuild components with layout primitives (#7950)
  [Backdrop] Call `onClick` regardless of `setClosing` prop presence (#8237)
laurkim pushed a commit that referenced this pull request Feb 3, 2023
@shopify-github-actions-access @github-actions
Version Packages (#8252)
2938830 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@10.26.0

### Minor Changes

- [#8240](#8240)
[`31abdab37`](31abdab)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack`
component


- [#8238](#8238)
[`bb8b551d4`](bb8b551)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard`
component

### Patch Changes

- [#8256](#8256)
[`43776be71`](43776be)
Thanks [@aveline](https://github.com/aveline)! - - Fixed `Bleed` width
behavior
    -   Fixed `Banner` content width


- [#8244](#8244)
[`0ee432500`](0ee4325)
Thanks [@samrose3](https://github.com/samrose3)! - Disallow
text-transform property in Stylelint Polaris

- Updated dependencies
\[[`1b1394d32`](1b1394d)]:
    -   @shopify/polaris-tokens@6.4.0

## @shopify/polaris-tokens@6.4.0

### Minor Changes

- [#8245](#8245)
[`1b1394d32`](1b1394d)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added new z-index
tokens that will be the default in v7.0.0

## @shopify/stylelint-polaris@5.2.0

### Minor Changes

- [#8244](#8244)
[`0ee432500`](0ee4325)
Thanks [@samrose3](https://github.com/samrose3)! - Disallow
text-transform property in Stylelint Polaris

### Patch Changes

- Updated dependencies
\[[`1b1394d32`](1b1394d)]:
    -   @shopify/polaris-tokens@6.4.0

## @shopify/polaris-cli@0.1.2

### Patch Changes

-   Updated dependencies \[]:
    -   @shopify/polaris-migrator@0.11.4

## @shopify/polaris-migrator@0.11.4

### Patch Changes

- Updated dependencies
\[[`1b1394d32`](1b1394d),
[`0ee432500`](0ee4325)]:
    -   @shopify/polaris-tokens@6.4.0
    -   @shopify/stylelint-polaris@5.2.0

## polaris.shopify.com@0.32.0

### Minor Changes

- [#8240](#8240)
[`31abdab37`](31abdab)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack`
component


- [#8238](#8238)
[`bb8b551d4`](bb8b551)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard`
component

### Patch Changes

- Updated dependencies
\[[`43776be71`](43776be),
[`31abdab37`](31abdab),
[`1b1394d32`](1b1394d),
[`0ee432500`](0ee4325),
[`bb8b551d4`](bb8b551)]:
    -   @shopify/polaris@10.26.0
    -   @shopify/polaris-tokens@6.4.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@gwyneplaine gwyneplaine mentioned this pull request Feb 14, 2023
Merged
@lgriffee lgriffee mentioned this pull request Feb 15, 2023
Closed
sam-b-rose added a commit that referenced this pull request May 26, 2023
@lgriffee @tmlayton
@Bringer128 @aveline @kyledurand @itwasmattgregg @alex-page @laurkim @BPScott @aaronccasanova @sam-b-rose @mrcthms @chloerice @heyjoethomas @shopify-github-actions-access @github-actions
@shopify/polaris v11.0.0 major release (#7597)
9e1350e 
## @shopify/polaris v11.0.0

### Dependencies

- [x] #8200

### NodeJS

- [x] #8201

### TypeScript

- [x] #8203

### Components

- [x] #7349
- [x] #7397
- [x] #7962
- [x] #8187
- [x] #8184
- [x] #8206
- [x] #7990
- [x] #8468
- [x] #8577
- [x] #8631
- [x] #8962

## @shopify/polaris-tokens v7.0.0

### Tokens
- [x] #6920
- [x] #8245
- [x] #4826
- [x] #8405

## @shopify/stylelint-polaris v7.0.0
- [x] #7622
- [x] #8419

# Post @shopify/polaris v11 shipping
- [ ] #8420

## Low priority or not ready breaking changes
- [x] Remove deprecated layout components
- [x] Release Layout primitive components

---------

Co-authored-by: Tim Layton <tmlayton@users.noreply.github.com>
Co-authored-by: Ryan Musgrave <ryan.musgrave@shopify.com>
Co-authored-by: Ryan Musgrave <ryanm128@gmail.com>
Co-authored-by: aveline <aveline@users.noreply.github.com>
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
Co-authored-by: Matt Gregg <matt.gregg@shopify.com>
Co-authored-by: Alex Page <hi@alexpage.dev>
Co-authored-by: Lo Kim <lo.kim@shopify.com>
Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com>
Co-authored-by: Sam Rose <sam.rose@shopify.com>
Co-authored-by: Marc Thomas <marc.thomas@shopify.com>
Co-authored-by: Alex Page <19199063+alex-page@users.noreply.github.com>
Co-authored-by: Chloe Rice <18447883+chloerice@users.noreply.github.com>
Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
Co-authored-by: Joe Thomas <joe.thomas@shopify.com>
Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com>
Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@lgriffee @alex-page
@aaronccasanova @juzser
Add new z-index token names (Shopify#8245)
f44cbb3 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

We want to rename these tokens in v11. By adding the new names in v10 we
can break up the major version bump into more manageable chunks (we can
create and run migrations for the values in v10 and then just remove the
values in the launch of v11).

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

<!--
  Summary of the changes committed.

Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.

If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:

    <details>
      <summary>Summary of your gif(s)</summary>
      <img src="..." alt="Description of what the gif shows">
    </details>
-->

<!-- ℹ️ Delete the following for small / trivial changes -->

Adds a set of identical z-index tokens with the names `--p-z-index-*`
(vs. `--p-z-*`)

---------

Co-authored-by: Alex Page <hi@alexpage.dev>
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@shopify-github-actions-access @github-actions @juzser
Version Packages (Shopify#8252)
92610ba 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris@10.26.0

### Minor Changes

- [Shopify#8240](Shopify#8240)
[`31abdab37`](Shopify@31abdab)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack`
component


- [Shopify#8238](Shopify#8238)
[`bb8b551d4`](Shopify@bb8b551)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard`
component

### Patch Changes

- [Shopify#8256](Shopify#8256)
[`43776be71`](Shopify@43776be)
Thanks [@aveline](https://github.com/aveline)! - - Fixed `Bleed` width
behavior
    -   Fixed `Banner` content width


- [Shopify#8244](Shopify#8244)
[`0ee432500`](Shopify@0ee4325)
Thanks [@samrose3](https://github.com/samrose3)! - Disallow
text-transform property in Stylelint Polaris

- Updated dependencies
\[[`1b1394d32`](Shopify@1b1394d)]:
    -   @shopify/polaris-tokens@6.4.0

## @shopify/polaris-tokens@6.4.0

### Minor Changes

- [Shopify#8245](Shopify#8245)
[`1b1394d32`](Shopify@1b1394d)
Thanks [@lgriffee](https://github.com/lgriffee)! - Added new z-index
tokens that will be the default in v7.0.0

## @shopify/stylelint-polaris@5.2.0

### Minor Changes

- [Shopify#8244](Shopify#8244)
[`0ee432500`](Shopify@0ee4325)
Thanks [@samrose3](https://github.com/samrose3)! - Disallow
text-transform property in Stylelint Polaris

### Patch Changes

- Updated dependencies
\[[`1b1394d32`](Shopify@1b1394d)]:
    -   @shopify/polaris-tokens@6.4.0

## @shopify/polaris-cli@0.1.2

### Patch Changes

-   Updated dependencies \[]:
    -   @shopify/polaris-migrator@0.11.4

## @shopify/polaris-migrator@0.11.4

### Patch Changes

- Updated dependencies
\[[`1b1394d32`](Shopify@1b1394d),
[`0ee432500`](Shopify@0ee4325)]:
    -   @shopify/polaris-tokens@6.4.0
    -   @shopify/stylelint-polaris@5.2.0

## polaris.shopify.com@0.32.0

### Minor Changes

- [Shopify#8240](Shopify#8240)
[`31abdab37`](Shopify@31abdab)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyStack`
component


- [Shopify#8238](Shopify#8238)
[`bb8b551d4`](Shopify@bb8b551)
Thanks [@laurkim](https://github.com/laurkim)! - Added `LegacyCard`
component

### Patch Changes

- Updated dependencies
\[[`43776be71`](Shopify@43776be),
[`31abdab37`](Shopify@31abdab),
[`1b1394d32`](Shopify@1b1394d),
[`0ee432500`](Shopify@0ee4325),
[`bb8b551d4`](Shopify@bb8b551)]:
    -   @shopify/polaris@10.26.0
    -   @shopify/polaris-tokens@6.4.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@lgriffee @tmlayton
@Bringer128 @aveline @kyledurand @itwasmattgregg @alex-page @laurkim @BPScott @aaronccasanova @sam-b-rose @mrcthms @chloerice @heyjoethomas @shopify-github-actions-access @github-actions @juzser
@shopify/polaris v11.0.0 major release (Shopify#7597)
7201283 
## @shopify/polaris v11.0.0

### Dependencies

- [x] Shopify#8200

### NodeJS

- [x] Shopify#8201

### TypeScript

- [x] Shopify#8203

### Components

- [x] Shopify#7349
- [x] Shopify#7397
- [x] Shopify#7962
- [x] Shopify#8187
- [x] Shopify#8184
- [x] Shopify#8206
- [x] Shopify#7990
- [x] Shopify#8468
- [x] Shopify#8577
- [x] Shopify#8631
- [x] Shopify#8962

## @shopify/polaris-tokens v7.0.0

### Tokens
- [x] Shopify#6920
- [x] Shopify#8245
- [x] Shopify#4826
- [x] Shopify#8405

## @shopify/stylelint-polaris v7.0.0
- [x] Shopify#7622
- [x] Shopify#8419

# Post @shopify/polaris v11 shipping
- [ ] Shopify#8420

## Low priority or not ready breaking changes
- [x] Remove deprecated layout components
- [x] Release Layout primitive components

---------

Co-authored-by: Tim Layton <tmlayton@users.noreply.github.com>
Co-authored-by: Ryan Musgrave <ryan.musgrave@shopify.com>
Co-authored-by: Ryan Musgrave <ryanm128@gmail.com>
Co-authored-by: aveline <aveline@users.noreply.github.com>
Co-authored-by: Kyle Durand <kyledurand@users.noreply.github.com>
Co-authored-by: Matt Gregg <matt.gregg@shopify.com>
Co-authored-by: Alex Page <hi@alexpage.dev>
Co-authored-by: Lo Kim <lo.kim@shopify.com>
Co-authored-by: Ben Scott <227292+BPScott@users.noreply.github.com>
Co-authored-by: Aaron Casanova <32409546+aaronccasanova@users.noreply.github.com>
Co-authored-by: Sam Rose <11774595+samrose3@users.noreply.github.com>
Co-authored-by: Sam Rose <sam.rose@shopify.com>
Co-authored-by: Marc Thomas <marc.thomas@shopify.com>
Co-authored-by: Alex Page <19199063+alex-page@users.noreply.github.com>
Co-authored-by: Chloe Rice <18447883+chloerice@users.noreply.github.com>
Co-authored-by: Chloe Rice <chloerice@users.noreply.github.com>
Co-authored-by: Joe Thomas <joe.thomas@shopify.com>
Co-authored-by: Yuraima Estevez <yuraima.estevez@shopify.com>
Co-authored-by: shopify-github-actions-access[bot] <109624739+shopify-github-actions-access[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-page alex-page alex-page approved these changes

@aaronccasanova aaronccasanova aaronccasanova approved these changes

Assignees

@lgriffee lgriffee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lgriffee @alex-page @aaronccasanova