Add accessibility tests for experimental #9847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophschneider
force-pushed
the
sophie/experimental-accessibility
branch
from
6e871a6 to
82f519f
Compare
sophschneider
added
the
🤖Skip Changelog
sophschneider
force-pushed
the
sophie/experimental-accessibility
branch
from
82f519f to
b40ea92
Compare
sophschneider
force-pushed
the
sophie/experimental-accessibility
branch
from
b40ea92 to
48d291b
Compare
sophschneider
force-pushed
the
sophie/experimental-accessibility
branch
2 times, most recently
from
3ed41b2 to
bbbc821
Compare
sophschneider
removed
the
🤖Skip Changelog
sophschneider
force-pushed
the
sophie/experimental-accessibility
branch
from
bbbc821 to
73a260e
Compare
sophschneider
changed the title
sophschneider
requested review from
jesstelford,
yurm04,
sam-b-rose,
chloerice,
laurkim and
aaronccasanova
sam-b-rose
approved these changes
Jul 28, 2023
|
We will eventually want to remove this additional CI check once we are ready to make se23 the default. I think it is a good idea to keep testing both for a bit. |
sam-b-rose
reviewed
Jul 28, 2023
aaronccasanova
approved these changes
Jul 28, 2023
fortmarek
pushed a commit
that referenced
this pull request
Aug 3, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@7.8.0 ### Minor Changes - [#9858](#9858) [`3fc3d5923`](3fc3d59) Thanks [@ardakaracizmeli](https://github.com/ardakaracizmeli)! - Added SidekickMajor - [#9871](#9871) [`bac86a621`](bac86a6) Thanks [@fortmarek](https://github.com/fortmarek)! - Added displayName to transpiled icons - [#9854](#9854) [`5dabf0fe0`](5dabf0f) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Updated CancelMajor and CancelMinor icons ## @shopify/polaris@11.11.0 ### Minor Changes - [#9697](#9697) [`c078d5d85`](c078d5d) Thanks [@nat-king](https://github.com/nat-king)! - Added optional prop `TextDecorationLine` to `Text` to include a line-through decoration ### Patch Changes - [#9847](#9847) [`85b68a358`](85b68a3) Thanks [@qt314](https://github.com/qt314)! - Added `role` prop to `VerticalStack` - [#9863](#9863) [`4061fd04d`](4061fd0) Thanks [@zakwarsame](https://github.com/zakwarsame)! - Fixed ActionList item overflow and tooltip zIndex - Updated dependencies \[[`3fc3d5923`](3fc3d59), [`bac86a621`](bac86a6), [`5dabf0fe0`](5dabf0f)]: - @shopify/polaris-icons@7.8.0 ## @shopify/polaris-cli@0.2.29 ## polaris.shopify.com@0.56.7 ### Patch Changes - Updated dependencies \[[`3fc3d5923`](3fc3d59), [`85b68a358`](85b68a3), [`bac86a621`](bac86a6), [`4061fd04d`](4061fd0), [`5dabf0fe0`](5dabf0f), [`c078d5d85`](c078d5d)]: - @shopify/polaris-icons@7.8.0 - @shopify/polaris@11.11.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
### WHY are these changes introduced? Fixes [this issue ](Shopify/archive-polaris-backlog-2024#1030) ### WHAT is this pull request doing? Adds a duplicate CI check to run the accessibility tests on storybook with the `polarisSummerEditions2023` feature flag forced to true. I do this with a [Storybook Env Variable](https://storybook.js.org/docs/react/configure/environment-variables). I also had to fix some minor a11y failures, which included adding an `aria-role` to `VerticalStack` <img width="696" alt="Screenshot 2023-07-28 at 10 23 02 AM" src="https://github.com/Shopify/polaris/assets/20652326/6e692f41-f704-4f5d-ac2e-6f2b542e9ca6"> ### How to 🎩 * Make sure the new CI passes! * `aria-role='menu'` is on `Box` pre se23 and on `VerticalStack` post se23 in [`ActionList`](https://5d559397bae39100201eedc1-fbggpulucd.chromatic.com/?path=/story/all-components-actionlist--all)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes this issue
WHAT is this pull request doing?
Adds a duplicate CI check to run the accessibility tests on storybook with the
polarisSummerEditions2023feature flag forced to true. I do this with a Storybook Env Variable.I also had to fix some minor a11y failures, which included adding an
aria-roletoVerticalStackHow to 🎩
aria-role='menu'is onBoxpre se23 and onVerticalStackpost se23 inActionList