[Icons] Cancel Icons updates #9854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated CancelMajor and CancelMinor icons
kyledurand
approved these changes
Jul 28, 2023
fortmarek
pushed a commit
that referenced
this pull request
Aug 3, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@7.8.0 ### Minor Changes - [#9858](#9858) [`3fc3d5923`](3fc3d59) Thanks [@ardakaracizmeli](https://github.com/ardakaracizmeli)! - Added SidekickMajor - [#9871](#9871) [`bac86a621`](bac86a6) Thanks [@fortmarek](https://github.com/fortmarek)! - Added displayName to transpiled icons - [#9854](#9854) [`5dabf0fe0`](5dabf0f) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Updated CancelMajor and CancelMinor icons ## @shopify/polaris@11.11.0 ### Minor Changes - [#9697](#9697) [`c078d5d85`](c078d5d) Thanks [@nat-king](https://github.com/nat-king)! - Added optional prop `TextDecorationLine` to `Text` to include a line-through decoration ### Patch Changes - [#9847](#9847) [`85b68a358`](85b68a3) Thanks [@qt314](https://github.com/qt314)! - Added `role` prop to `VerticalStack` - [#9863](#9863) [`4061fd04d`](4061fd0) Thanks [@zakwarsame](https://github.com/zakwarsame)! - Fixed ActionList item overflow and tooltip zIndex - Updated dependencies \[[`3fc3d5923`](3fc3d59), [`bac86a621`](bac86a6), [`5dabf0fe0`](5dabf0f)]: - @shopify/polaris-icons@7.8.0 ## @shopify/polaris-cli@0.2.29 ## polaris.shopify.com@0.56.7 ### Patch Changes - Updated dependencies \[[`3fc3d5923`](3fc3d59), [`85b68a358`](85b68a3), [`bac86a621`](bac86a6), [`4061fd04d`](4061fd0), [`5dabf0fe0`](5dabf0f), [`c078d5d85`](c078d5d)]: - @shopify/polaris-icons@7.8.0 - @shopify/polaris@11.11.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
Updated `CancelMajor` and `CancelMinor` icons to be slightly larger to
have better optical alignment.
<!--
Summary of the changes committed.
Before / after screenshots are appreciated for UI changes. Make sure to
include alt text that describes the screenshot.
If you include an animated gif showing your change, wrapping it in a
details tag is recommended. Gifs usually autoplay, which can cause
accessibility issues for people reviewing your PR:
<details>
<summary>Summary of your gif(s)</summary>
<img src="..." alt="Description of what the gif shows">
</details>
-->
<!-- ℹ️ Delete the following for small / trivial changes -->
### How to 🎩
🖥 [Local development
instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development)
🗒 [General tophatting
guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md)
📄 [Changelog
guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog)
<!--
Give as much information as needed to experiment with the component
in the playground.
-->
<details>
<summary>Copy-paste this code in
<code>playground/Playground.tsx</code>:</summary>
```jsx
import React from 'react';
import {Page} from '../src';
export function Playground() {
return (
<Page title="Playground">
{/* Add the code you want to test in here */}
</Page>
);
}
```
</details>
### 🎩 checklist
- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
CancelMajorandCancelMinoricons to be slightly larger to have better optical alignment.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes