This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Remove ruby-locking extension #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloyesp
requested review from
a team,
pepicrft and
jesalerno84
and removed request for
a team
pepicrft
reviewed
Oct 20, 2021
| @@ -33,11 +33,7 @@ Gem::Specification.new do |spec| | |||
| end | |||
| spec.bindir = "bin" | |||
| spec.require_paths = ["lib", "vendor"] | |||
| spec.extensions = ["ext/shopify-cli/extconf.rb"] | |||
There was a problem hiding this comment.
Considering we are running tests against multiple versions of Ruby, I think this type of locking is no longer necessary. We haven't had the need lately to debug mult-Ruby environments.
pepicrft
approved these changes
Oct 26, 2021
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #1663
WHAT is this pull request doing?
It removes the extension used to install the executable and adds the executable to the gemspec.
How to test your changes?
If it keeps installing it should be good to go, but as the original version is installing executables in absolute paths it will not upgrade nicely.
Update checklist