Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Remove ruby-locking extension #1664

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Remove ruby-locking extension #1664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 0 additions & 60 deletions ext/shopify-cli/extconf.rb
View file
Open in desktop

This file was deleted.

6 changes: 1 addition & 5 deletions shopify-cli.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,7 @@ Gem::Specification.new do |spec|
end
spec.bindir = "bin"
spec.require_paths = ["lib", "vendor"]
spec.extensions = ["ext/shopify-cli/extconf.rb"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering we are running tests against multiple versions of Ruby, I think this type of locking is no longer necessary. We haven't had the need lately to debug mult-Ruby environments.

# Do NOT include `shopify` as a listed executable via `spec.executables`.
# `ext/shopify-cli/extconf.rb` will dynamically create a script and soft-link
# `/usr/local/bin/shopify` to that script, in order to "lock" the Ruby used to
# a single Ruby (useful for debugging in multi-Ruby environments)
spec.executables << "shopify"

spec.add_development_dependency("bundler", "~> 2.2.2")
spec.add_development_dependency("rake", "~> 12.3", ">= 12.3.3")
Expand Down