This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Changes required to be compatible with the pivot extensible discount scripts #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuncanUszkay1
requested review from
pepicrft and
jesalerno84
and removed request for
a team
DuncanUszkay1
commented
Oct 22, 2021
| @@ -35,7 +35,7 @@ def self.migrations(migrations_directory:) | |||
| file_name = File.basename(file_path).gsub(".rb", "") | |||
| file_name_components = file_name.split("_") | |||
| date_timestamp = file_name_components[0].to_i | |||
| migration_name = file_name_components[1...].join("_") | |||
| migration_name = file_name_components.drop(1).join("_") | |||
There was a problem hiding this comment.
[1,2,3].drop(1) == [1,2,3][1...]
|
https://github.com/Shopify/shopify-cli/runs/3981041402?check_suite_focus=true This is failing, but appears unrelated to my changes |
andrewhassan
approved these changes
Oct 25, 2021
pepicrft
approved these changes
Oct 26, 2021
|
Thanks for fixing this @DuncanUszkay1. I pushed a CHANGELOG.md update to list the changes and ran rubocop to fix some linting issues. I'll merge once CI is ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues that we had to resolve to use the Shopify CLI's scripts features with pivot
WHY are these changes introduced?
The migrator doesn't properly load with ruby 2.5, I'm not sure why. I get a consistent syntax error:
The package name for discounts was pointing at the checkout package when it actually should have been the discount package, this causes script deploys with
discount-typesto fail.WHAT is this pull request doing?
[1...]to the equivalentdrop(1).drop(1)is stable over versions since1.8.6. I would have assumed the same about the array range syntax, but couldn't quite get it to work. I'd like to get this in since it's blocking our local dev environment.How to test your changes?
The fastest way is to use pivot, which will automatically deploy a script for you: https://github.com/Shopify/pivot.
Note that this won't work until https://github.com/Shopify/pivot/pull/12 is merged.
Post-release steps
This is just to unblock our dev team, shouldn't require any special release procedures
Update checklist
I've added a CHANGELOG entry for this PR (if the change is public-facing)Not public facing.