Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Changes required to be compatible with the pivot extensible discount scripts #1678

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Changes required to be compatible with the pivot extensible discount scripts #1678

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4836f1b
Changes required to be compatible with the pivot extensible discounts…
DuncanUszkay1 Oct 22, 2021
16d74fb
Update CHANGELOG
Oct 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/project_types/script/config/extension_points.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,5 @@ discount_types:
libraries:
typescript:
beta: true
package: "@shopify/scripts-checkout-apis-temp"
package: "@shopify/scripts-discount-apis"
repo: "https://github.com/Shopify/scripts-apis-examples"
2 changes: 1 addition & 1 deletion lib/shopify_cli/migrator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def self.migrations(migrations_directory:)
file_name = File.basename(file_path).gsub(".rb", "")
file_name_components = file_name.split("_")
date_timestamp = file_name_components[0].to_i
migration_name = file_name_components[1...].join("_")
migration_name = file_name_components.drop(1).join("_")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[1,2,3].drop(1) == [1,2,3][1...]


Migrator::Migration.new(
name: migration_name,
Expand Down