Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.58.2 #6471

Merged
merged 17 commits into from
Nov 19, 2024
Merged

Release/v0.58.2 #6471

merged 17 commits into from
Nov 19, 2024

Conversation

prashant-shahi
Copy link
Member

@prashant-shahi prashant-shahi commented Nov 19, 2024

Summary

  • release SigNoz v0.58.2

Important

Update SigNoz to v0.58.2 with enhancements in trace handling, telemetry, and refactoring.

  • Version Update:
    • Update SigNoz version to v0.58.2 in docker-compose.yaml, docker-compose-minimal.yaml, and docker-compose.testing.yaml.
  • Trace Handling:
    • Add enrich.go and enrich_test.go for trace query enrichment in v4.
    • Modify query_builder_test.go to include new test cases for trace queries.
  • Telemetry:
    • Add anomalyBasedAlerts to telemetry data in telemetry.go.
  • Refactoring:
    • Remove deprecated span filter functions from reader.go and http_handler.go.
    • Update GetListTsRanges in logs.go and logs_test.go.
  • Miscellaneous:
    • Update Alpine base image in Dockerfile to 3.20.3.
    • Add useRef in BasicInfo.tsx to prevent duplicate event logging.
    • Add refetchChannels function in ChannelSelect/index.tsx.

This description was created by Ellipsis for 9ccc686. It will automatically update as commits are pushed.

nityanandagohain and others added 16 commits November 15, 2024 22:13
* feat: support for window based pagination in new trace v4

* fix: update pagination logic

* fix: update comment

* fix: substract correct length

* fix: revert changes

* fix: add tests for querier

* fix: rename matcher

* fix: handle offset inmemory for list queries in traces

* fix: correct var name

* fix: add max pagination limit for traces
* feat: support for new enrichment logic in traces

* fix: default test added

* fix: update func name in links

* Update pkg/query-service/utils/logs_test.go

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>

---------

Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
…channels on opening the channels dropdown (#6416)

* feat: add channel creation option and auto-refresh channels list on dropdown open

* chore: move inline styles to style.ts

* fix: show the prompt to ask admin if the user doesn't have permissions

* fix: display create channel option only if the user has permission

* fix: prevent repeated new alert event logs + log new channel option inside dropdown
* feat: use the license v2 key to fill licenses v3 on startup

* chore: make the init only if the licenses v2 is present

* chore: address review comments
Signed-off-by: Prashant Shahi <prashant@signoz.io>
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 9ccc686 in 1 minute and 50 seconds

More details
  • Looked at 3159 lines of code in 31 files
  • Skipped 0 files when reviewing.
  • Skipped posting 8 drafted comments based on config settings.
1. frontend/src/container/FormAlertRules/BasicInfo.tsx:218
  • Draft comment:
    Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment seems to be misplaced as there is no evidence of inline styles in the code. The code uses styled components and external stylesheets, which aligns with best practices. Therefore, the comment does not seem to be about a change made in this diff.
    I might be missing some context or other parts of the codebase where inline styles are used, but based on the provided code, there is no indication of inline styles.
    Given the provided code, there is no evidence of inline styles, so the comment seems irrelevant to the changes made.
    The comment should be deleted as it does not pertain to any changes made in the diff and there is no evidence of inline styles in the provided code.
2. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:48
  • Draft comment:
    Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.
3. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:49
  • Draft comment:
    Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.
4. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:50
  • Draft comment:
    Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.
5. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:51
  • Draft comment:
    Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.
6. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:52
  • Draft comment:
    Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.
7. frontend/src/container/FormAlertRules/ChannelSelect/index.tsx:53
  • Draft comment:
    Avoid using inline styles in React components. Instead, use external stylesheets, CSS classes, or styled components. This comment applies to other instances of inline styles in this file as well.
  • Reason this comment was not posted:
    Marked as duplicate.
8. pkg/query-service/app/traces/v4/enrich.go:65
  • Draft comment:
    Duplicate of existing function EnrichTracesQuery in pkg/query-service/app/traces/v3/query_builder.go. Consider reusing the existing function.

  • function EnrichTracesQuery (query_builder.go)

  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_TTKTBOalJmck4vzV


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

pkg/query-service/rules/base_rule.go Show resolved Hide resolved
pkg/query-service/app/traces/v4/enrich.go Show resolved Hide resolved
@prashant-shahi prashant-shahi merged commit c8d0f76 into main Nov 19, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants